Skip to content

Commit 033a04e

Browse files
committed
fix(organization): simplify Reconcile method
1 parent 5955795 commit 033a04e

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

internal/controller/organization_controller.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ type OrganizationReconciler struct {
4646
//+kubebuilder:rbac:groups=garm-operator.mercedes-benz.com,namespace=xxxxx,resources=organizations/status,verbs=get;update;patch
4747
//+kubebuilder:rbac:groups=garm-operator.mercedes-benz.com,namespace=xxxxx,resources=organizations/finalizers,verbs=update
4848

49-
func (r *OrganizationReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
49+
func (r *OrganizationReconciler) Reconcile(ctx context.Context, req ctrl.Request) (res ctrl.Result, retErr error) {
5050
log := log.FromContext(ctx)
5151

5252
organizationClient := garmClient.NewOrganizationClient()
@@ -61,12 +61,6 @@ func (r *OrganizationReconciler) Reconcile(ctx context.Context, req ctrl.Request
6161
return ctrl.Result{}, err
6262
}
6363

64-
return r.reconcile(ctx, organizationClient, organization)
65-
}
66-
67-
func (r *OrganizationReconciler) reconcile(ctx context.Context, organizationClient garmClient.OrganizationClient, organization *garmoperatorv1beta1.Organization) (res ctrl.Result, retErr error) {
68-
log := log.FromContext(ctx)
69-
7064
initialOrganization := organization.DeepCopy()
7165

7266
// Ignore objects that are paused

internal/controller/organization_controller_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,9 @@ func TestOrganizationReconciler_reconcileNormal(t *testing.T) {
928928
mockOrganizationClient := mock.NewMockOrganizationClient(mockCtrl)
929929
tt.expectGarmRequest(mockOrganizationClient.EXPECT())
930930

931-
_, err = reconciler.reconcile(context.Background(), mockOrganizationClient, organization)
931+
organization.InitializeConditions()
932+
933+
_, err = reconciler.reconcileNormal(context.Background(), mockOrganizationClient, organization)
932934
if (err != nil) != tt.wantErr {
933935
t.Errorf("OrganizationReconciler.reconcileNormal() error = %v, wantErr %v", err, tt.wantErr)
934936
return

0 commit comments

Comments
 (0)