feat: allow to configure api_keys by cli (#2154)

* feat: allow to configure api_keys by cli

* fix: typo

* chore: add comment

---------

Co-authored-by: sangjanai <sang@jan.ai>

Author: vansangpfiev

engine/cli/command_line_parser.cc

@@ -437,7 +437,7 @@ void CommandLineParser::SetupConfigsCommands() {
 
     auto is_empty = true;
     for (const auto& [key, value] : config_update_opts_) {
-      if (!value.empty()) {
+      if (!value.empty() || key == "api_keys") {
         is_empty = false;
         break;
       }

engine/cli/commands/config_upd_cmd.cc

@@ -2,6 +2,7 @@
 #include "commands/server_start_cmd.h"
 #include "common/api_server_configuration.h"
 #include "utils/curl_utils.h"
+#include "utils/file_manager_utils.h"
 #include "utils/logging_utils.h"
 #include "utils/string_utils.h"
 #include "utils/url_parser.h"
@@ -46,22 +47,40 @@ inline Json::Value NormalizeJson(
 void commands::ConfigUpdCmd::Exec(
     const std::string& host, int port,
     const std::unordered_map<std::string, std::string>& options) {
-  if (!commands::IsServerAlive(host, port)) {
-    CLI_LOG("Starting server ...");
-    commands::ServerStartCmd ssc;
-    if (!ssc.Exec(host, port)) {
-      return;
-    }
-  }
 
   auto non_null_opts = std::unordered_map<std::string, std::string>();
   for (const auto& [key, value] : options) {
-    if (value.empty()) {
+    // In case of api_keys, we allow empty value
+    if (value.empty() && key != "api_keys") {
       continue;
     }
     non_null_opts[key] = value;
   }
 
+  if (non_null_opts.size() == 1) {
+    for (const auto& [key, value] : non_null_opts) {
+      if (key == "api_keys") {
+        auto config = file_manager_utils::GetCortexConfig();
+        config.apiKeys = string_utils::SplitBy(value, ",");
+        auto result = file_manager_utils::UpdateCortexConfig(config);
+        if (result.has_error()) {
+          CLI_LOG_ERROR(result.error());
+        } else {
+          CLI_LOG("Configuration updated successfully!");
+        }
+        return;
+      }
+    }
+  }
+
+  if (!commands::IsServerAlive(host, port)) {
+    CLI_LOG("Starting server ...");
+    commands::ServerStartCmd ssc;
+    if (!ssc.Exec(host, port)) {
+      return;
+    }
+  }
+
   auto url = url_parser::Url{
       .protocol = "http",
       .host = host + ":" + std::to_string(port),

engine/common/api_server_configuration.h

@@ -97,6 +97,15 @@ static const std::unordered_map<std::string, ApiConfigurationMetadata>
                                   .accept_value = "string",
                                   .default_value = "",
                                   .allow_empty = true}},
+        {"api_keys",
+         ApiConfigurationMetadata{
+             .name = "api_keys",
+             .desc = "API header key to get access to server APIs",
+             .group = "Token",
+             .accept_value = "comma separated",
+             .default_value = "",
+             .allow_empty = true}},
+
 };
 
 class ApiServerConfiguration {

engine/main.cc

@@ -255,6 +255,12 @@ void RunServer(std::optional<std::string> host, std::optional<int> port,
     static const std::unordered_set<std::string> public_endpoints = {
         "/openapi.json", "/healthz", "/processManager/destroy"};
 
+    if (req->getHeader("Authorization").empty() &&
+        req->path() == "/v1/configs") {
+      CTL_WRN("Require API key to access /v1/configs");
+      return false;
+    }
+    
     // If API key is not set, skip validation
     if (api_keys.empty()) {
       return true;