Skip to content

Commit bf6e6b8

Browse files
Merge pull request #13 from melihyarikkaya/development
Development
2 parents 023ba53 + 1266344 commit bf6e6b8

File tree

5 files changed

+323
-256
lines changed

5 files changed

+323
-256
lines changed

android/src/main/java/com/melihyarikkaya/rnserialport/RNSerialportModule.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -276,9 +276,9 @@ public void stopUsbService() {
276276
}
277277

278278
@ReactMethod
279-
public void getDeviceList(Callback callback) {
279+
public void getDeviceList(Promise promise) {
280280
if(!usbServiceStarted) {
281-
callback.invoke(createError(Definitions.ERROR_USB_SERVICE_NOT_STARTED, Definitions.ERROR_USB_SERVICE_NOT_STARTED_MESSAGE));
281+
promise.reject(String.valueOf(Definitions.ERROR_USB_SERVICE_NOT_STARTED), Definitions.ERROR_USB_SERVICE_NOT_STARTED_MESSAGE);
282282
return;
283283
}
284284

@@ -287,7 +287,8 @@ public void getDeviceList(Callback callback) {
287287
HashMap<String, UsbDevice> devices = manager.getDeviceList();
288288

289289
if(devices.isEmpty()) {
290-
callback.invoke(createError(Definitions.ERROR_DEVICE_NOT_FOUND, Definitions.ERROR_DEVICE_NOT_FOUND_MESSAGE));
290+
//promise.reject(String.valueOf(Definitions.ERROR_DEVICE_NOT_FOUND), Definitions.ERROR_DEVICE_NOT_FOUND_MESSAGE);
291+
promise.resolve(Arguments.createArray());
291292
return;
292293
}
293294

@@ -303,11 +304,7 @@ public void getDeviceList(Callback callback) {
303304
deviceList.pushMap(map);
304305
}
305306

306-
WritableMap map = Arguments.createMap();
307-
map.putBoolean("status", true);
308-
map.putArray("devices", deviceList);
309-
310-
callback.invoke(map);
307+
promise.resolve(deviceList);
311308
}
312309

313310
@ReactMethod

doc-wiki/Manual-Connection.md

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ componentDidMount() {
5757
**Some precautions**
5858

5959
```javascript
60-
componentWillUnmount = async() => {
60+
componentWillUnmount = async () => {
6161
DeviceEventEmitter.removeAllListeners();
6262
const isOpen = await RNSerialport.isOpen();
6363
if (isOpen) {
6464
Alert.alert("isOpen", isOpen);
6565
RNSerialport.disconnect();
6666
}
6767
RNSerialport.stopUsbService();
68-
}
68+
};
6969
```
7070

7171
_Installation Successfuly_
@@ -163,7 +163,7 @@ class ManualConnection extends Component {
163163
RNSerialport.setReturnedDataType(this.state.returnedDataType);
164164
RNSerialport.setAutoConnect(false);
165165
RNSerialport.startUsbService();
166-
};
166+
}
167167

168168
stopUsbListener = async () => {
169169
DeviceEventEmitter.removeAllListeners();
@@ -235,18 +235,23 @@ class ManualConnection extends Component {
235235
}
236236
this.setState({ output: data });
237237
}
238-
fillDeviceList() {
239-
RNSerialport.getDeviceList(response => {
240-
if (response.status) {
241-
this.setState({ deviceList: response.devices });
238+
fillDeviceList = async () => {
239+
try {
240+
const deviceList = await RNSerialport.getDeviceList();
241+
if (deviceList.length > 0) {
242+
this.setState({ deviceList });
242243
} else {
243-
Alert.alert(
244-
"Error from getDeviceList()",
245-
response.errorCode + " " + response.errorMessage
246-
);
244+
this.setState({
245+
deviceList: [{ name: "Device Not Found", placeholder: true }]
246+
});
247247
}
248-
});
249-
}
248+
} catch (err) {
249+
Alert.alert(
250+
"Error from getDeviceList()",
251+
err.errorCode + " " + err.errorMessage
252+
);
253+
}
254+
};
250255
devicePickerItems() {
251256
return this.state.deviceList.map((device, index) =>
252257
!device.placeholder ? (

0 commit comments

Comments
 (0)