«--notemp» does not recreate «new directory created in the current directory» but unpack all files to old directory with same name #300
Description
On documentation we see
«
--notemp : The generated archive will not extract the files to a temporary directory, but in a new directory created in the current directory. This is better to distribute software packages that may extract and compile by themselves (i.e. launch the compilation through the embedded script).
»
Consider that directory named «out».
If the directory named out already exists, we expect that if the --nooverwrite tag is not used, the old out directory will be deleted and the content will be unpacked to a new, clean out directory.
What we have now («makeself-2.4.5») is that makeself unpacks content to the subdirectory out, overwriting existing files, but keeping old files (which may remain from previous installations, for example), thus tainting the installation process.
We're not sure if this is a bug or a feature, but we don't see a way to get a clean out directory while unpacking. The --cleanup option is available, but it's not reliable and doesn't guarantee that the out directory will always be clean or absent.