Skip to content

Commit 3f621da

Browse files
authored
Merge pull request #253 from mediaelement/release_3.0.1
release 3.0.1
2 parents 6820c52 + 2e2841b commit 3f621da

File tree

9 files changed

+27
-17
lines changed

9 files changed

+27
-17
lines changed

changelog.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Version History
22

3+
## *3.0.1 (2024/03/11)*
4+
### QUALITY PLUGIN
5+
* Icon Visibility Fix: The quality icon will now remain visible and functional across all quality adjustments.
6+
* Improved Option Naming: The option `iconPath` has been renamed to `iconPathQuality` to enhance clarity and consistency.
7+
8+
### A11Y PLUGIN
9+
* Improved Option Naming: The option `iconSpritePath` has been renamed to `iconSpritePathA11y` to enhance clarity and consistency.
10+
311
## *3.0.0 (2024/03/06)*
412
### QUALITY PLUGIN
513
#### New Feature: Inline SVG icons for quality button

dist/a11y/a11y.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Object.assign(mejs.MepDefaults, {
3333

3434
audioDescriptionCanPlay: false,
3535

36-
iconSpritePath: 'mejs-a11y-icons.svg'
36+
iconSpritePathA11y: 'mejs-a11y-icons.svg'
3737
});
3838

3939
Object.assign(MediaElementPlayer.prototype, {
@@ -69,12 +69,12 @@ Object.assign(MediaElementPlayer.prototype, {
6969
return node.className.indexOf(className) > -1;
7070
});
7171
},
72-
_generateIconHtml: function _generateIconHtml(id, classPrefix, iconSpritePath, iconId) {
73-
return '<svg xmlns="http://www.w3.org/2000/svg" id="' + id + '" class="' + classPrefix + iconId + '" aria-hidden="true" focusable="false">\n <use xlink:href="' + iconSpritePath + '#' + iconId + '"></use></svg>';
72+
_generateIconHtml: function _generateIconHtml(id, classPrefix, iconSpritePathA11y, iconId) {
73+
return '<svg xmlns="http://www.w3.org/2000/svg" id="' + id + '" class="' + classPrefix + iconId + '" aria-hidden="true" focusable="false">\n <use xlink:href="' + iconSpritePathA11y + '#' + iconId + '"></use></svg>';
7474
},
7575
_createAudioDescription: function _createAudioDescription() {
7676
var t = this;
77-
var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePath, 'icon-audio');
77+
var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePathA11y, 'icon-audio');
7878
var audioDescriptionTitle = mejs.i18n.t('mejs.a11y-audio-description');
7979
var audioDescriptionButton = document.createElement('div');
8080
audioDescriptionButton.className = t.options.classPrefix + 'button ' + t.options.classPrefix + 'audio-description-button';
@@ -91,7 +91,7 @@ Object.assign(MediaElementPlayer.prototype, {
9191
},
9292
_createVideoDescription: function _createVideoDescription() {
9393
var t = this;
94-
var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePath, 'icon-video');
94+
var iconHtml = t._generateIconHtml(t.id, t.options.classPrefix, t.options.iconSpritePathA11y, 'icon-video');
9595
var videoDescriptionTitle = mejs.i18n.t('mejs.a11y-video-description');
9696
var videoDescriptionButton = document.createElement('div');
9797
videoDescriptionButton.className = t.options.classPrefix + 'button ' + t.options.classPrefix + 'video-description-button';

dist/a11y/a11y.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)