Skip to content

Review environment sets WILDCARD_ENBALED=true which disables origin-checks in the cloud function #13354

@argl

Description

@argl

Summary

Lately some usage of resources under /shared-assets have been merged into content that were failing on stage and prod environments. Example

The issue has been resolved by allowing main and interactive examples origins as well for these assets by the cloud function's proxy.

The reason why this problem did not come up earlier is that the review environment has WILDCARD_ENABLED set, which basically disables all origin-checks in the cloud function.

For better parity with the prod and stage environments, it would be helpful to lock the origin check down there as well, maybe with something like *.review.mdn.allizom.org as the main origin.

URL

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_anchor_positioning/Using#setting_a_position-area

Reproduction steps

  1. See this issue in content

Expected behavior

I want the same behaviour in review/prod/stage environments

Actual behavior

Shared assets on the review environment worked, but failed on prod/stage environments

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

No response

Anything else?

No response

Validations

Metadata

Metadata

Assignees

No one assigned

    Labels

    cloud-functionneeds triageTriage needed by staff and/or partners. Automatically applied when an issue is opened.p2We want to address this but may have other higher priority items.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions