Controller - return/if fixes

Author: hamishwillee

controllers/bookController.js

@@ -142,11 +142,12 @@ exports.book_create_post = [
         book,
         errors: errors.array(),
       });
-    } else {
-      // Data from form is valid. Save book.
-      await book.save();
-      res.redirect(book.url);
+      return;
     }
+
+    // Data from form is valid. Save book.
+    await book.save();
+    res.redirect(book.url);
   }),
 ];
 

controllers/genreController.js

@@ -73,11 +73,12 @@ exports.genre_create_post = [
     if (genreExists) {
       // Genre exists, redirect to its detail page.
       res.redirect(genreExists.url);
-    } else {
-      await genre.save();
-      // New genre saved. Redirect to genre detail page.
-      res.redirect(genre.url);
+      return;
     }
+
+    // New genre. Save and redirect to its detail page.
+    await genre.save();
+    res.redirect(genre.url);
   }),
 ];