Skip to content

Commit 7f70b04

Browse files
committed
ci: Remove pointless '&&' command chaining
This script is run with 'set -e' and will fail if any subcommand fails. There is no reason to chain a bunch of commands together with '&&' and it only serves to make the script more difficult to read and edit. Signed-off-by: David Brown <david.brown@linaro.org>
1 parent 41da99d commit 7f70b04

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

ci/fih-tests_run.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@ source $(dirname "$0")/fih-tests_version.sh
2020

2121
# Note that we are pulling from a github mirror of these repos, not direct upstream. If the sha
2222
# checked out below changes, the mirrors might need to be updated.
23-
pushd .. &&\
24-
git clone https://github.com/mcu-tools/trusted-firmware-m &&\
25-
pushd trusted-firmware-m &&\
26-
git checkout eb8ff0db7d657b77abcd0262d5bf7f38eb1e1cdc &&\
27-
source lib/ext/tf-m-tests/version.txt &&\
28-
popd &&\
29-
git clone https://github.com/mcu-tools/tf-m-tests.git &&\
30-
pushd tf-m-tests &&\
31-
git checkout $version &&\
32-
popd
23+
pushd ..
24+
git clone https://github.com/mcu-tools/trusted-firmware-m
25+
pushd trusted-firmware-m
26+
git checkout eb8ff0db7d657b77abcd0262d5bf7f38eb1e1cdc
27+
source lib/ext/tf-m-tests/version.txt
28+
popd
29+
git clone https://github.com/mcu-tools/tf-m-tests.git
30+
pushd tf-m-tests
31+
git checkout $version
32+
popd
3333

3434
if [[ $GITHUB_ACTIONS == true ]]; then
3535
if [[ -z $FIH_ENV ]]; then

0 commit comments

Comments
 (0)