Addressing Julia's comments on uncaught promise rejections in validation

Author: Dtphelan1

src/client/BaseClient.js

@@ -43,19 +43,23 @@ class BaseClient {
     // Using Reduce to compute the validity of all extractors
     const allExtractorsValid = await this.extractors.reduce(async (curExtractorsValid, curExtractor) => {
       const { name } = curExtractor.constructor;
-
       if (curExtractor.validate) {
         logger.debug(`Validating ${name}`);
-        const isExtractorValid = await curExtractor.validate();
-        if (isExtractorValid) {
-          logger.debug(`Extractor ${name} PASSED CSV validation`);
-        } else {
+        try {
+          const isExtractorValid = await curExtractor.validate();
+          if (isExtractorValid) {
+            logger.debug(`Extractor ${name} PASSED CSV validation`);
+          } else {
+            logger.warn(`Extractor ${name} FAILED CSV validation`);
+          }
+          return ((await curExtractorsValid) && isExtractorValid);
+        } catch (e) {
           logger.warn(`Extractor ${name} FAILED CSV validation`);
+          return false;
         }
-        return (curExtractorsValid && isExtractorValid);
       }
       return curExtractorsValid;
-    }, true);
+    }, Promise.resolve(true));
 
     if (allExtractorsValid) {
       logger.info('Validation succeeded');

src/modules/CSVURLModule.js

@@ -20,7 +20,7 @@ class CSVURLModule {
       const csvData = await axios.get(this.url)
         .then((res) => res.data)
         .catch((e) => {
-          logger.error('Error occurred when getting CSV data using url');
+          logger.error('Error occurred when making a connection to this url');
           throw e;
         });
       logger.debug('Web request successful');
@@ -29,7 +29,7 @@ class CSVURLModule {
         columns: (header) => header.map((column) => stringNormalizer(column)),
         bom: true,
       });
-      logger.debug('Data parsing successful');
+      logger.debug('CSV Data parsing successful');
       this.data = normalizeEmptyValues(parsedData, this.unalterableColumns);
     }
   }