Merge pull request #107 from mcode/byte-order-mark-parsing

CSV Module now ignores BOMs

Author: mgramigna

src/modules/CSVModule.js

@@ -5,7 +5,7 @@ const logger = require('../helpers/logger');
 
 class CSVModule {
   constructor(csvFilePath) {
-    this.data = parse(fs.readFileSync(csvFilePath), { columns: true });
+    this.data = parse(fs.readFileSync(csvFilePath), { columns: true, bom: true });
   }
 
   async get(key, value, fromDate, toDate) {

test/modules/CSVModule.test.js

@@ -4,12 +4,18 @@ const exampleResponse = require('./fixtures/csv-response.json');
 
 const INVALID_MRN = 'INVALID MRN';
 const csvModule = new CSVModule(path.join(__dirname, './fixtures/example-csv.csv'));
+const csvModuleWithBOMs = new CSVModule(path.join(__dirname, './fixtures/example-csv-bom.csv'));
 
 test('Reads data from CSV', async () => {
   const data = await csvModule.get('mrn', 'example-mrn-1');
   expect(data).toEqual(exampleResponse);
 });
 
+test('Reads data from CSV with a Byte Order Mark', async () => {
+  const data = await csvModuleWithBOMs.get('mrn', 'example-mrn-1');
+  expect(data).toEqual(exampleResponse);
+});
+
 test('Returns multiple rows', async () => {
   const data = await csvModule.get('mrn', 'example-mrn-2');
   expect(data).toHaveLength(2);

test/modules/fixtures/example-csv-bom.csv

@@ -0,0 +1,4 @@
+mrn,trialSubjectID,enrollmentStatus,trialResearchID,trialStatus,dateRecorded
+example-mrn-1,subjectId-1,status-1,researchId-1,trialStatus-1,2020-01-10
+example-mrn-2,subjectId-2,status-2,researchId-2,trialStatus-2,2020-01-10
+example-mrn-2,subjectId-3,status-3,researchId-3,trialStatus-3,2020-06-10