can read from CSV's with empty lines and empty values

Author: Dtphelan1

src/modules/CSVFileModule.js

@@ -11,6 +11,8 @@ class CSVFileModule {
     const parsedData = parse(fs.readFileSync(csvFilePath), {
       columns: (header) => header.map((column) => stringNormalizer(column)),
       bom: true,
+      skip_empty_lines: true,
+      skip_records_with_empty_values: true,
     });
     this.filePath = csvFilePath;
 

test/modules/CSVFileModule.test.js

@@ -4,7 +4,6 @@ const exampleResponse = require('./fixtures/csv-response.json');
 
 const INVALID_MRN = 'INVALID MRN';
 const csvFileModule = new CSVFileModule(path.join(__dirname, './fixtures/example-csv.csv'));
-const csvFileModuleWithBOMs = new CSVFileModule(path.join(__dirname, './fixtures/example-csv-bom.csv'));
 
 
 describe('CSVFileModule', () => {
@@ -15,10 +14,30 @@ describe('CSVFileModule', () => {
     });
 
     test('Reads data from CSV with a Byte Order Mark', async () => {
+      const csvFileModuleWithBOMs = new CSVFileModule(
+        path.join(__dirname, './fixtures/example-csv-empty-values.csv'),
+      );
+
       const data = await csvFileModuleWithBOMs.get('mrn', 'example-mrn-1');
       expect(data).toEqual(exampleResponse);
     });
 
+    test('Reads data from CSV with Empty Values', async () => {
+      const csvFileModuleWithEmptyValues = new CSVFileModule(
+        path.join(__dirname, './fixtures/example-csv-empty-values.csv'),
+      );
+      const data = await csvFileModuleWithEmptyValues.get('mrn', 'example-mrn-1');
+      expect(data).toEqual(exampleResponse);
+    });
+
+    test('Reads data from CSV with Empty Lines', async () => {
+      const csvFileModuleWithEmptyLines = new CSVFileModule(
+        path.join(__dirname, './fixtures/example-csv-empty-line.csv'),
+      );
+      const data = await csvFileModuleWithEmptyLines.get('mrn', 'example-mrn-1');
+      expect(data).toEqual(exampleResponse);
+    });
+
     test('Returns multiple rows', async () => {
       const data = await csvFileModule.get('mrn', 'example-mrn-2');
       expect(data).toHaveLength(2);

test/modules/fixtures/example-csv-empty-line.csv

@@ -0,0 +1,4 @@
+mrn,trialSubjectID,enrollmentStatus,trialResearchID,trialStatus,dateRecorded
+example-mrn-1,subjectId-1,status-1,researchId-1,trialStatus-1,2020-01-10
+
+example-mrn-2,subjectId-3,status-3,researchId-3,trialStatus-3,2020-06-10

test/modules/fixtures/example-csv-empty-values.csv

@@ -0,0 +1,4 @@
+mrn,trialSubjectID,enrollmentStatus,trialResearchID,trialStatus,dateRecorded
+example-mrn-1,subjectId-1,status-1,researchId-1,trialStatus-1,2020-01-10
+, ,    , \t\t\t,,\t
+example-mrn-2,subjectId-3,status-3,researchId-3,trialStatus-3,2020-06-10