Addressed error messages in tests; removed old code and replaced with comments

Author: Dtphelan1

src/helpers/valueSetUtils.js

@@ -31,7 +31,7 @@ function loadVs(absoluteFilepath, typeOfVS) {
       throw Error('No defined valueset loader for `turtle` type valuesets');
 
     default:
-      throw Error(`${typeOfVS}' is not a recognized valueset type`);
+      throw Error(`'${typeOfVS}' is not a recognized valueset type`);
   }
 }
 
@@ -49,14 +49,16 @@ const checkCodeInVs = (code, valueSetFilePath, typeOfVS = vsTypes.json) => {
     // If valueSet has expansion, we only need to check these codes
     inVSExpansion = valueSet.expansion.contains.some((containsItem) => {
       if (!code || !containsItem) return false;
-      // return code.system === containsItem.system && code === containsItem.code;
+      // NOTE: This is a technically incorrect interpretation of ValueSets;
+      //       this matching ought to check both code and system
       return code === containsItem.code;
     });
   } else {
     // Checks if code is in any of the valueSet.compose.include arrays
     inVSCompose = valueSet.compose.include.some((includeItem) => {
       if (!code || !includeItem || !includeItem.concept) return false;
-      // return c.system === includeItem.system && includeItem.concept.map((concept) => concept.code).includes(code);
+      // NOTE: This is a technically incorrect interpretation of ValueSets;
+      //       this matching ought to check both code and system
       return includeItem.concept.map((concept) => concept.code).includes(code);
     });
   }

test/helpers/valueSetUtils.test.js

@@ -20,7 +20,7 @@ describe('valueSetUtils', () => {
       expect(() => loadJsonVs()).toThrow();
     });
     test('should throw when file does not exist', () => {
-      expect(() => loadJsonVs('./path/does/not/exist')).toThrow();
+      expect(() => loadJsonVs('./path/does/not/exist')).toThrow("ENOENT: no such file or directory, open './path/does/not/exist'");
     });
     test('should load from the supplied filepath', () => {
       const valueSetFilePath = path.resolve(__dirname, 'fixtures', 'valueset-without-expansion.json');
@@ -30,13 +30,13 @@ describe('valueSetUtils', () => {
 
   describe('loadVs', () => {
     test('should throw an error when xml type is provided', () => {
-      expect(() => loadVs(undefined, vsTypes.xml)).toThrow();
+      expect(() => loadVs(undefined, vsTypes.xml)).toThrow('No defined valueset loader for `xml` type valuesets');
     });
     test('should throw an error when turtle is provided', () => {
-      expect(() => loadVs(undefined, vsTypes.turtle)).toThrow();
+      expect(() => loadVs(undefined, vsTypes.turtle)).toThrow('No defined valueset loader for `turtle` type valuesets');
     });
     test('should throw an error when an unrecoginized type is provided', () => {
-      expect(() => loadVs(undefined, vsTypes.newType)).toThrow();
+      expect(() => loadVs(undefined, vsTypes.newType)).toThrow("'undefined' is not a recognized valueset type");
     });
     test('Should load a vs properly for json', () => {
       const valueSetFilePath = path.resolve(__dirname, 'fixtures', 'valueset-without-expansion.json');