updated tests and error message

Author: Dtphelan1

src/helpers/contextUtils.js

@@ -18,12 +18,12 @@ function getPatientFromContext(mrn, context) {
 * @return {Array} All the conditions entries found in context
 */
 function getConditionEntriesFromContext(context) {
-  logger.debug('Getting conditions from context');
+  logger.debug('Getting condition entries from context');
   const conditionEntriesInContext = getBundleEntriesByResourceType(context, 'Condition', {}, false);
   if (conditionEntriesInContext.length === 0) {
     throw Error('Could not find any conditions in context; ensure that a ConditionExtractor is used earlier in your extraction configuration');
   }
-  logger.debug(`Condition resources found in context. Found ${conditionEntriesInContext.length} condition resources.`);
+  logger.debug(`Condition entries found in context. Found ${conditionEntriesInContext.length} condition resources.`);
   return conditionEntriesInContext;
 }
 
@@ -33,12 +33,12 @@ function getConditionEntriesFromContext(context) {
 * @return {Array} All the conditions resources found in context
 */
 function getConditionsFromContext(context) {
-  logger.debug('Getting conditions from context');
+  logger.debug('Getting condition resources from context');
   const conditionsResourcesInContext = getBundleResourcesByType(context, 'Condition', {}, false);
   if (_.isEmpty(conditionsResourcesInContext)) {
-    throw Error('Could not find conditions in context; ensure that a ConditionExtractor is used earlier in your extraction configuration');
+    throw Error('Could not find any conditions in context; ensure that a ConditionExtractor is used earlier in your extraction configuration');
   }
-  logger.debug('Condition resources found in context.');
+  logger.debug(`Condition resources found in context. Found ${conditionsResourcesInContext.length} condition resources.`);
   return conditionsResourcesInContext;
 }
 

test/helpers/contextUtils.test.js

@@ -50,19 +50,19 @@ describe('getConditionsFromContext', () => {
       },
     ],
   };
-  test('Should return Patient resource in context', () => {
-    const conditions = getConditionsFromContext(MOCK_PATIENT_MRN, conditionContext);
+  test('Should return Condition resource in context', () => {
+    const conditions = getConditionsFromContext(conditionContext);
     expect(conditions).toContain(conditionResource);
     expect(conditions).toContain(conditionResource2);
   });
 
   test('Should throw an error if there is no patient in context', () => {
-    expect(() => getConditionsFromContext(MOCK_PATIENT_MRN, {}))
-      .toThrow('Could not find conditions in context; ensure that a ConditionExtractor is used earlier in your extraction configuration');
+    expect(() => getConditionsFromContext({}))
+      .toThrow('Could not find any conditions in context; ensure that a ConditionExtractor is used earlier in your extraction configuration');
   });
 });
 
-describe('getConditionFromContext', () => {
+describe('getConditionEntriesFromContext', () => {
   const conditionResource = {
     resourceType: 'Condition',
     id: 'mCODEConditionExample01',
@@ -82,8 +82,8 @@ describe('getConditionFromContext', () => {
     ],
   };
 
-  test('Should return all Condition resources in context', () => {
-    const conditions = getConditionEntriesFromContext(MOCK_PATIENT_MRN, conditionContext);
+  test('Should return all Condition entries in context', () => {
+    const conditions = getConditionEntriesFromContext(conditionContext);
     expect(conditions).toHaveLength(2);
     expect(conditions[0]).toEqual({
       fullUrl: 'context-url-1',
@@ -92,7 +92,7 @@ describe('getConditionFromContext', () => {
   });
 
   test('Should throw an error if there are no conditions in context', () => {
-    expect(() => getConditionEntriesFromContext(MOCK_PATIENT_MRN, {}))
+    expect(() => getConditionEntriesFromContext({}))
       .toThrow('Could not find any conditions in context; ensure that a ConditionExtractor is used earlier in your extraction configuration');
   });
 });