Merge pull request #173 from mcode/fix-notification-info-case-logic

dmendelowitz · web-flow · commit 917400a45348 · 2022-01-10T10:53:48.000-05:00
Fixed improper demorgans-law case logic for logger warning
diff --git a/src/application/tools/emailNotifications.js b/src/application/tools/emailNotifications.js
@@ -58,7 +58,10 @@ async function sendEmailNotification(notificationInfo, errors, debug = false) {
   }
 
   // Ensure that the tlsRejectUnauthorized property is a boolean
-  if (notificationInfo.tlsRejectUnauthorized && (notificationInfo.tlsRejectUnauthorized !== true || notificationInfo.tlsRejectUnauthorized !== false)) {
+  if (
+    notificationInfo.tlsRejectUnauthorized
+    && typeof notificationInfo.tlsRejectUnauthorized !== 'boolean'
+  ) {
     logger.warn('The notificationInfo.tlsRejectUnauthorized should be a boolean value. The value provided will not be used.');
   }
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,10 @@ async function sendEmailNotification(notificationInfo, errors, debug = false) {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`// Ensure that the tlsRejectUnauthorized property is a boolean`
`61`		`- if (notificationInfo.tlsRejectUnauthorized && (notificationInfo.tlsRejectUnauthorized !== true \|\| notificationInfo.tlsRejectUnauthorized !== false)) {`
	`61`	`+ if (`
	`62`	`+ notificationInfo.tlsRejectUnauthorized`
	`63`	`+ && typeof notificationInfo.tlsRejectUnauthorized !== 'boolean'`
	`64`	`+ ) {`
`62`	`65`	`logger.warn('The notificationInfo.tlsRejectUnauthorized should be a boolean value. The value provided will not be used.');`
`63`	`66`	`}`
`64`	`67`