fixed the flag; new tests

Author: Dtphelan1

src/modules/CSVFileModule.js

@@ -15,9 +15,11 @@ class CSVFileModule {
       // https://csv.js.org/parse/options/skip_empty_lines/
       skip_empty_lines: true,
       // NOTE: This will skip any records with empty values, not just skip the empty values themselves
+      // NOTE-2: The name of the flag changed from v4 (what we use) to v5 (what is documented)
       // https://csv.js.org/parse/options/skip_records_with_empty_values/
-      skip_records_with_empty_values: true,
+      skip_lines_with_empty_values: true,
     });
+
     this.filePath = csvFilePath;
     this.data = normalizeEmptyValues(parsedData, unalterableColumns);
   }

test/modules/CSVFileModule.test.js

@@ -23,11 +23,17 @@ describe('CSVFileModule', () => {
     });
 
     test('Reads data from CSV with Empty Values', async () => {
+      // Five row file, with three rows of empty values
+      // Should be just two rows of data after ingestion
       const csvFileModuleWithEmptyValues = new CSVFileModule(
         path.join(__dirname, './fixtures/example-csv-empty-values.csv'),
       );
       const data = await csvFileModuleWithEmptyValues.get('mrn', 'example-mrn-1');
       expect(data).toEqual(exampleResponse);
+      const data2 = await csvFileModuleWithEmptyValues.get('mrn', 'example-mrn-not-ignored');
+      expect(data2).toHaveLength(1);
+      // Should be just two rows of data after ingestion
+      expect(csvFileModuleWithEmptyValues.data).toHaveLength(2);
     });
 
     test('Reads data from CSV with Empty Lines', async () => {

test/modules/fixtures/example-csv-empty-values.csv

@@ -1,4 +1,6 @@
 mrn,trialSubjectID,enrollmentStatus,trialResearchID,trialStatus,dateRecorded
 example-mrn-1,subjectId-1,status-1,researchId-1,trialStatus-1,2020-01-10
-, ,    , \t\t\t,,\t
-example-mrn-2,subjectId-3,status-3,researchId-3,trialStatus-3,2020-06-10
+, , , , , 
+,    ,   ,    ,,
+,,,		,	,
+example-mrn-not-ignored,,,,,