Only add tlsRejectUnauthorized if it is a boolean. Add tests to check various config options for tls.

Author: jafeltra

src/cli/emailNotifications.js

@@ -57,10 +57,15 @@ async function sendEmailNotification(notificationInfo, errors, debug = false) {
     emailBody += 'The stack trace information can be seen in the terminal as well as in the notification email.';
   }
 
+  // Ensure that the tlsRejectUnauthorized property is a boolean
+  if (notificationInfo.tlsRejectUnauthorized && (notificationInfo.tlsRejectUnauthorized !== true || notificationInfo.tlsRejectUnauthorized !== false)) {
+    logger.warn('The notificationInfo.tlsRejectUnauthorized should be a boolean value. The value provided will not be used.');
+  }
+
   const transporter = nodemailer.createTransport({
     host: notificationInfo.host,
     ...(notificationInfo.port && { port: notificationInfo.port }),
-    ...(notificationInfo.tlsRejectUnauthorized !== undefined && { tls: { rejectUnauthorized: notificationInfo.tlsRejectUnauthorized } }),
+    ...((notificationInfo.tlsRejectUnauthorized === true || notificationInfo.tlsRejectUnauthorized === false) && { tls: { rejectUnauthorized: notificationInfo.tlsRejectUnauthorized } }),
   });
 
   logger.debug('Sending email with error information');

test/cli/emailNotifications.test.js

@@ -80,7 +80,7 @@ describe('sendEmailNotification', () => {
     };
 
     await expect(sendEmailNotification(notificationInfo, errors, false)).resolves.not.toThrow();
-    expect(createTransportSpy).toBeCalledWith({ host: notificationInfo.host, port: notificationInfo.port, tls: { rejectUnauthorized: false } });
+    expect(createTransportSpy).toBeCalledWith({ host: notificationInfo.host, port: notificationInfo.port, tls: { rejectUnauthorized: notificationInfo.tlsRejectUnauthorized } });
     expect(sendMailMock).toBeCalled();
     const sendMailMockArgs = sendMailMock.mock.calls[0][0];
     expect(sendMailMockArgs.to).toEqual(notificationInfo.to);
@@ -94,6 +94,48 @@ describe('sendEmailNotification', () => {
     expect(sendMailMockArgs.text).not.toMatch(/Error at line 4`/i);
   });
 
+  it('should send an email with tlsRejectUnauthorized set to true, false, and not set', async () => {
+    const notificationInfoTLSFalse = {
+      host: 'my.host.com',
+      to: ['something@example.com', 'someone@example.com'],
+      tlsRejectUnauthorized: false,
+    };
+    const notificationInfoTLSTrue = {
+      host: 'my.host.com',
+      to: ['something@example.com', 'someone@example.com'],
+      tlsRejectUnauthorized: true,
+    };
+    const notificationInfoNoTLS = {
+      host: 'my.host.com',
+      to: ['something@example.com', 'someone@example.com'],
+    };
+    const notificationInfoUnexpectedTLS = {
+      host: 'my.host.com',
+      to: ['something@example.com', 'someone@example.com'],
+      tlsRejectUnauthorized: 'true', // Any value that is not true or false will log a warning and not be used
+    };
+    const errors = {
+      0: [],
+      1: [{ message: 'something bad', stack: 'Error at line 1' }],
+    };
+    createTransportSpy.mockReturnValueOnce({ sendMail: sendMailMock });
+    await expect(sendEmailNotification(notificationInfoTLSFalse, errors, false)).resolves.not.toThrow();
+    expect(createTransportSpy).toBeCalledWith({ host: notificationInfoTLSFalse.host, port: notificationInfoTLSFalse.port, tls: { rejectUnauthorized: false } });
+
+    createTransportSpy.mockReturnValueOnce({ sendMail: sendMailMock });
+    await expect(sendEmailNotification(notificationInfoTLSTrue, errors, false)).resolves.not.toThrow();
+    expect(createTransportSpy).toBeCalledWith({ host: notificationInfoTLSTrue.host, port: notificationInfoTLSTrue.port, tls: { rejectUnauthorized: true } });
+
+    createTransportSpy.mockReturnValueOnce({ sendMail: sendMailMock });
+    await expect(sendEmailNotification(notificationInfoNoTLS, errors, false)).resolves.not.toThrow();
+    expect(createTransportSpy).toBeCalledWith({ host: notificationInfoNoTLS.host, port: notificationInfoNoTLS.port }); // No tls object set
+
+    createTransportSpy.mockReturnValueOnce({ sendMail: sendMailMock });
+    await expect(sendEmailNotification(notificationInfoUnexpectedTLS, errors, false)).resolves.not.toThrow();
+    // A warning will be logged and the unexpected value will not be used
+    expect(createTransportSpy).toBeCalledWith({ host: notificationInfoUnexpectedTLS.host, port: notificationInfoUnexpectedTLS.port });
+  });
+
   it('should send an email with stack traces if debug flag was used', async () => {
     createTransportSpy.mockReturnValueOnce({ sendMail: sendMailMock });
     const notificationInfo = {