diff --git a/src/lmic/lmic_as923.c b/src/lmic/lmic_as923.c index f46f50b0..bc0404f4 100644 --- a/src/lmic/lmic_as923.c +++ b/src/lmic/lmic_as923.c @@ -173,9 +173,7 @@ static CONST_TABLE(u4_t, iniChannelFreq)[NUM_DEFAULT_CHANNELS] = { AS923_F2 | BAND_CENTI, }; -// as923 ignores join, becuase the channel setup is the same either way. -void LMICas923_initDefaultChannels(bit_t join) { - LMIC_API_PARAMETER(join); +void LMICas923_initDefaultChannels() { os_clearMem(&LMIC.channelFreq, sizeof(LMIC.channelFreq)); #if !defined(DISABLE_MCMD_DlChannelReq) diff --git a/src/lmic/lmic_bandplan_as923.h b/src/lmic/lmic_bandplan_as923.h index 16f4518d..a23bc337 100644 --- a/src/lmic/lmic_bandplan_as923.h +++ b/src/lmic/lmic_bandplan_as923.h @@ -96,8 +96,8 @@ ostime_t LMICas923_nextTx(ostime_t now); ostime_t LMICas923_nextJoinState(void); #define LMICbandplan_nextJoinState() LMICas923_nextJoinState() -void LMICas923_initDefaultChannels(bit_t join); -#define LMICbandplan_initDefaultChannels(join) LMICas923_initDefaultChannels(join) +void LMICas923_initDefaultChannels(); +#define LMICbandplan_initDefaultChannels() LMICas923_initDefaultChannels() // override default for LMICbandplan_updateTX #undef LMICbandplan_updateTx diff --git a/src/lmic/lmic_bandplan_eu868.h b/src/lmic/lmic_bandplan_eu868.h index efff7d5c..3e1f5111 100644 --- a/src/lmic/lmic_bandplan_eu868.h +++ b/src/lmic/lmic_bandplan_eu868.h @@ -78,8 +78,8 @@ ostime_t LMICeu868_nextTx(ostime_t now); ostime_t LMICeu868_nextJoinState(void); #define LMICbandplan_nextJoinState() LMICeu868_nextJoinState() -void LMICeu868_initDefaultChannels(bit_t join); -#define LMICbandplan_initDefaultChannels(join) LMICeu868_initDefaultChannels(join) +void LMICeu868_initDefaultChannels(); +#define LMICbandplan_initDefaultChannels() LMICeu868_initDefaultChannels() #undef LMICbandplan_nextJoinTime ostime_t LMICeu868_nextJoinTime(ostime_t now); diff --git a/src/lmic/lmic_bandplan_in866.h b/src/lmic/lmic_bandplan_in866.h index dad10cab..ea6995d8 100644 --- a/src/lmic/lmic_bandplan_in866.h +++ b/src/lmic/lmic_bandplan_in866.h @@ -75,8 +75,8 @@ ostime_t LMICin866_nextTx(ostime_t now); ostime_t LMICin866_nextJoinState(void); #define LMICbandplan_nextJoinState() LMICin866_nextJoinState() -void LMICin866_initDefaultChannels(bit_t join); -#define LMICbandplan_initDefaultChannels(join) LMICin866_initDefaultChannels(join) +void LMICin866_initDefaultChannels(); +#define LMICbandplan_initDefaultChannels() LMICin866_initDefaultChannels() void LMICin866_setRx1Params(void); #define LMICbandplan_setRx1Params() LMICin866_setRx1Params() diff --git a/src/lmic/lmic_bandplan_kr920.h b/src/lmic/lmic_bandplan_kr920.h index 2c22f227..c0a5225a 100644 --- a/src/lmic/lmic_bandplan_kr920.h +++ b/src/lmic/lmic_bandplan_kr920.h @@ -78,8 +78,8 @@ ostime_t LMICkr920_nextTx(ostime_t now); ostime_t LMICkr920_nextJoinState(void); #define LMICbandplan_nextJoinState() LMICkr920_nextJoinState() -void LMICkr920_initDefaultChannels(bit_t join); -#define LMICbandplan_initDefaultChannels(join) LMICkr920_initDefaultChannels(join) +void LMICkr920_initDefaultChannels(); +#define LMICbandplan_initDefaultChannels() LMICkr920_initDefaultChannels() void LMICkr920_setRx1Params(void); #define LMICbandplan_setRx1Params() LMICkr920_setRx1Params() diff --git a/src/lmic/lmic_eu868.c b/src/lmic/lmic_eu868.c index f8d51d15..5afbad8e 100644 --- a/src/lmic/lmic_eu868.c +++ b/src/lmic/lmic_eu868.c @@ -91,14 +91,15 @@ ostime_t LMICeu868_dr2hsym(uint8_t dr) { enum { NUM_DEFAULT_CHANNELS = 3 }; -static CONST_TABLE(u4_t, iniChannelFreq)[6] = { - // Join frequencies and duty cycle limit (0.1%) - EU868_F1 | BAND_MILLI, EU868_F2 | BAND_MILLI, EU868_F3 | BAND_MILLI, +static CONST_TABLE(u4_t, iniChannelFreq)[NUM_DEFAULT_CHANNELS] = { // Default operational frequencies and duty cycle limit (1%) - EU868_F1 | BAND_CENTI, EU868_F2 | BAND_CENTI, EU868_F3 | BAND_CENTI, + EU868_F1 | BAND_CENTI, + EU868_F2 | BAND_CENTI, + EU868_F3 | BAND_CENTI, }; -void LMICeu868_initDefaultChannels(bit_t join) { +void LMICeu868_initDefaultChannels() { + os_clearMem(&LMIC.channelFreq, sizeof(LMIC.channelFreq)); #if !defined(DISABLE_MCMD_DlChannelReq) os_clearMem(&LMIC.channelDlFreq, sizeof(LMIC.channelDlFreq)); @@ -107,9 +108,8 @@ void LMICeu868_initDefaultChannels(bit_t join) { os_clearMem(&LMIC.bands, sizeof(LMIC.bands)); LMIC.channelMap = (1 << NUM_DEFAULT_CHANNELS) - 1; - u1_t su = join ? 0 : NUM_DEFAULT_CHANNELS; - for (u1_t fu = 0; fu