Fix #383: clean up compile warnings found by CI testing

Author: terrillmoore

examples/ttn-otaa-feather-us915-dht22/ttn-otaa-feather-us915-dht22.ino

@@ -112,14 +112,14 @@ void onEvent (ev_t ev) {
               Serial.print("devaddr: ");
               Serial.println(devaddr, HEX);
               Serial.print("artKey: ");
-              for (int i=0; i<sizeof(artKey); ++i) {
+              for (size_t i=0; i<sizeof(artKey); ++i) {
                 if (i != 0)
                   Serial.print("-");
                 Serial.print(artKey[i], HEX);
               }
               Serial.println("");
               Serial.print("nwkKey: ");
-              for (int i=0; i<sizeof(nwkKey); ++i) {
+              for (size_t i=0; i<sizeof(nwkKey); ++i) {
                       if (i != 0)
                               Serial.print("-");
                       Serial.print(nwkKey[i], HEX);

examples/ttn-otaa-feather-us915/ttn-otaa-feather-us915.ino

@@ -154,14 +154,14 @@ void onEvent (ev_t ev) {
               Serial.print("devaddr: ");
               Serial.println(devaddr, HEX);
               Serial.print("artKey: ");
-              for (int i=0; i<sizeof(artKey); ++i) {
+              for (size_t i=0; i<sizeof(artKey); ++i) {
                 if (i != 0)
                   Serial.print("-");
                 Serial.print(artKey[i], HEX);
               }
               Serial.println("");
               Serial.print("nwkKey: ");
-              for (int i=0; i<sizeof(nwkKey); ++i) {
+              for (size_t i=0; i<sizeof(nwkKey); ++i) {
                       if (i != 0)
                               Serial.print("-");
                       Serial.print(nwkKey[i], HEX);

examples/ttn-otaa-halconfig-us915/ttn-otaa-halconfig-us915.ino

@@ -108,14 +108,14 @@ void onEvent (ev_t ev) {
               Serial.print("devaddr: ");
               Serial.println(devaddr, HEX);
               Serial.print("artKey: ");
-              for (int i=0; i<sizeof(artKey); ++i) {
+              for (size_t i=0; i<sizeof(artKey); ++i) {
                 if (i != 0)
                   Serial.print("-");
                 Serial.print(artKey[i], HEX);
               }
               Serial.println("");
               Serial.print("nwkKey: ");
-              for (int i=0; i<sizeof(nwkKey); ++i) {
+              for (size_t i=0; i<sizeof(nwkKey); ++i) {
                       if (i != 0)
                               Serial.print("-");
                       Serial.print(nwkKey[i], HEX);

examples/ttn-otaa-network-time/ttn-otaa-network-time.ino

@@ -114,12 +114,12 @@ void onEvent (ev_t ev) {
               Serial.print("devaddr: ");
               Serial.println(devaddr, HEX);
               Serial.print("artKey: ");
-              for (int i=0; i<sizeof(artKey); ++i) {
+              for (size_t i=0; i<sizeof(artKey); ++i) {
                 Serial.print(artKey[i], HEX);
               }
               Serial.println("");
               Serial.print("nwkKey: ");
-              for (int i=0; i<sizeof(nwkKey); ++i) {
+              for (size_t i=0; i<sizeof(nwkKey); ++i) {
                 Serial.print(nwkKey[i], HEX);
               }
               Serial.println("");

examples/ttn-otaa/ttn-otaa.ino

@@ -113,12 +113,12 @@ void onEvent (ev_t ev) {
               Serial.print("devaddr: ");
               Serial.println(devaddr, HEX);
               Serial.print("artKey: ");
-              for (int i=0; i<sizeof(artKey); ++i) {
+              for (size_t i=0; i<sizeof(artKey); ++i) {
                 Serial.print(artKey[i], HEX);
               }
               Serial.println("");
               Serial.print("nwkKey: ");
-              for (int i=0; i<sizeof(nwkKey); ++i) {
+              for (size_t i=0; i<sizeof(nwkKey); ++i) {
                 Serial.print(nwkKey[i], HEX);
               }
               Serial.println("");

src/lmic/lmic.c

@@ -803,7 +803,7 @@ applyAdrRequests(
 
 static int
 scan_mac_cmds_link_adr(
-    const char *opts,
+    const uint8_t *opts,
     int olen,
     bit_t *presponse_fit
     )
@@ -868,7 +868,6 @@ scan_mac_cmds(
     int port
     ) {
     int oidx = 0;
-    bit_t fSawAdrReq = 0;
     uint8_t cmd;
 
     LMIC.pendMacLen = 0;

src/lmic/lmic_compliance.c

@@ -35,9 +35,7 @@ Copyright notice and license info:
 |
 \****************************************************************************/
 
-static void acDoJoin(void);
 static void acEnterActiveMode(void);
-static void acEnterTestMode(void);
 static void acExitActiveMode(void);
 static void acSendUplink(void);
 static void acSetTimer(ostime_t);
@@ -55,7 +53,9 @@ static void evEchoCommand(const uint8_t *pMessage, size_t nMessage);
 static lmic_event_cb_t lmicEventCb;
 static lmic_txmessage_cb_t sendUplinkCompleteCb;
 static osjobcbfn_t timerExpiredCb;
-static const char *txSuccessToString(int fSuccess);
+
+/* this is declared global so the optimizer can chuck it without warnings */
+const char *LMICcompliance_txSuccessToString(int fSuccess);
 
 /****************************************************************************\
 |
@@ -655,9 +655,6 @@ static void acEnterActiveMode(void) {
     LMIC_Compliance.state = LMIC_COMPLIANCE_STATE_ACTIVE;
 }
 
-static void acEnterTestMode(void) {
-}
-
 void acSetTimer(ostime_t delay) {
     os_setTimedCallback(&LMIC_Compliance.timerJob, os_getTime() + delay, timerExpiredCb);
 }
@@ -739,7 +736,7 @@ static void acSendUplink(void) {
 
 static void sendUplinkCompleteCb(void *pUserData, int fSuccess) {
     LMIC_Compliance.eventflags |= LMIC_COMPLIANCE_EVENT_UPLINK_COMPLETE;
-    LMIC_COMPLIANCE_PRINTF("%s(%s)\n", __func__, txSuccessToString(fSuccess));
+    LMIC_COMPLIANCE_PRINTF("%s(%s)\n", __func__, LMICcompliance_txSuccessToString(fSuccess));
     fsmEvalDeferred();
 }
 
@@ -762,6 +759,6 @@ static void acSendUplinkBuffer(void) {
     }
 }
 
-static const char *txSuccessToString(int fSuccess) {
+const char *LMICcompliance_txSuccessToString(int fSuccess) {
     return fSuccess ? "ok" : "failed";
 }