fixes per review

Author: d-a-v

src/arduino_lmic_hal_configuration.h

@@ -97,11 +97,14 @@ class HalConfiguration_t
 	// PA_BOOST mode. So that's our default. Override this
 	// for the Murata module.
 	virtual TxPowerPolicy_t getTxPowerPolicy(
-		__attribute__((unused)) TxPowerPolicy_t policy,
-		__attribute__((unused)) int8_t requestedPower,
-		__attribute__((unused)) uint32_t frequency
+		TxPowerPolicy_t policy,
+		int8_t requestedPower,
+		uint32_t frequency
 		)
 		{
+		LMIC_API_PARAMETER(policy);
+		LMIC_API_PARAMETER(requestedPower);
+		LMIC_API_PARAMETER(frequency);
 		// default: use PA_BOOST exclusively
 		return TxPowerPolicy_t::PA_BOOST;
 		}

src/lmic/lmic.c

@@ -295,7 +295,7 @@ ostime_t calcAirTime (rps_t rps, u1_t plen) {
 //
 
 static void setRxsyms (ostime_t rxsyms) {
-    if (rxsyms >= (ostime_t)(1 << 10u)) {
+    if (rxsyms >= (((ostime_t)1) << 10u)) {
         LMIC.rxsyms = (1u << 10u) - 1;
     } else if (rxsyms < 0) {
         LMIC.rxsyms = 0;
@@ -723,7 +723,7 @@ static CONST_TABLE(u1_t, macCmdSize)[] = {
 static u1_t getMacCmdSize(u1_t macCmd) {
     if (macCmd < 2)
         return 0;
-    if ((macCmd - 2) >= (u1_t)LENOF_TABLE(macCmdSize))
+    if (((size_t)(macCmd - 2)) >= LENOF_TABLE(macCmdSize))
         return 0;
     return TABLE_GET_U1(macCmdSize, macCmd - 2);
 }