Fix #820: don't reject bank enable w/ zero mask prematurely

terrillmoore · terrillmoore · commit 87aede82d350 · 2021-11-20T14:28:09.000-05:00
diff --git a/src/lmic/lmic_us_like.c b/src/lmic/lmic_us_like.c
@@ -111,8 +111,8 @@ bit_t LMICuslike_canMapChannels(u1_t chpage, u2_t chmap) {
 			return 1;
 		}
 	} else if (chpage == MCMD_LinkADRReq_ChMaskCntl_USLIKE_BANK) {
-		if (chmap == 0 || (chmap & 0xFF00) != 0) {
-			// no bits set, or reserved bitsset , fail.
+		if ((chmap & 0xFF00) != 0) {
+			// Reserved bits set, fail.
 			return 0;
 		}
 	} else if (chpage == MCMD_LinkADRReq_ChMaskCntl_USLIKE_125ON ||

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,8 @@ bit_t LMICuslike_canMapChannels(u1_t chpage, u2_t chmap) {`
`111`	`111`	`return 1;`
`112`	`112`	`}`
`113`	`113`	`} else if (chpage == MCMD_LinkADRReq_ChMaskCntl_USLIKE_BANK) {`
`114`		`- if (chmap == 0 \|\| (chmap & 0xFF00) != 0) {`
`115`		`- // no bits set, or reserved bitsset , fail.`
	`114`	`+ if ((chmap & 0xFF00) != 0) {`
	`115`	`+ // Reserved bits set, fail.`
`116`	`116`	`return 0;`
`117`	`117`	`}`
`118`	`118`	`} else if (chpage == MCMD_LinkADRReq_ChMaskCntl_USLIKE_125ON \|\|`