Merge pull request #472 from manuelbl/invalid_len_comparison

terrillmoore · web-flow · commit 5322dd19ef1a · 2019-10-07T18:24:51.000-04:00
Fix comparison for max data frame length
diff --git a/src/lmic/lmic.c b/src/lmic/lmic.c
@@ -1872,7 +1872,7 @@ static bit_t buildDataFrame (void) {
         LMIC.adrChanged = 0;
     }
 
-    u1_t flen = end + (txdata ? 5+dlen : 4);
+    unsigned int flen = end + (txdata ? 5+dlen : 4);
     if( flen > MAX_LEN_FRAME ) {
         // Options and payload too big - delay payload
         txdata = 0;

Original file line number	Diff line number	Diff line change
`@@ -1872,7 +1872,7 @@ static bit_t buildDataFrame (void) {`
`1872`	`1872`	`LMIC.adrChanged = 0;`
`1873`	`1873`	`}`
`1874`	`1874`
`1875`		`- u1_t flen = end + (txdata ? 5+dlen : 4);`
	`1875`	`+ unsigned int flen = end + (txdata ? 5+dlen : 4);`
`1876`	`1876`	`if( flen > MAX_LEN_FRAME ) {`
`1877`	`1877`	`// Options and payload too big - delay payload`
`1878`	`1878`	`txdata = 0;`