Skip to content

Commit 97bf2a1

Browse files
authored
Merge pull request #411 from viralpraxis/adopt-prism-v1.5-release
Adopt Prism v1.5 release
2 parents 10fb02d + a655f40 commit 97bf2a1

File tree

7 files changed

+18
-10
lines changed

7 files changed

+18
-10
lines changed

Gemfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ PATH
44
unparser (0.8.0)
55
diff-lcs (~> 1.6)
66
parser (>= 3.3.0)
7-
prism (>= 1.4)
7+
prism (>= 1.5.1)
88

99
GEM
1010
remote: https://rubygems.org/
@@ -38,7 +38,7 @@ GEM
3838
pp (0.6.2)
3939
prettyprint
4040
prettyprint (0.2.0)
41-
prism (1.4.0)
41+
prism (1.5.1)
4242
psych (5.2.6)
4343
date
4444
stringio
@@ -104,4 +104,4 @@ DEPENDENCIES
104104
unparser!
105105

106106
BUNDLED WITH
107-
2.6.2
107+
2.7.0

bin/parser-prism-round-trip-test

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ b\nar
6262
spanning_heredoc
6363
heredocs_with_fake_newlines
6464
heredocs_nested
65-
].to_set { |file| "#{PARSER_PATH}/test/prism/fixtures-tmp/#{file}.txt" }
65+
].tap { _1 << 'endless_methods_command_call' unless Gem::Version.new(RUBY_VERSION) >= '3.5' } # https://github.com/ruby/prism/pull/3639
66+
.tap { _1 << 'leading_logical' unless Gem::Version.new(RUBY_VERSION) >= '3.5' } # https://github.com/ruby/prism/pull/3337
67+
.to_set { |file| "#{PARSER_PATH}/test/prism/fixtures-tmp/#{file}.txt" }
6668
end
6769

6870
private

lib/unparser/emitter/block.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def emit_target
5151
emit_send_target
5252
when :lambda
5353
visit(target)
54-
emit_lambda_arguments unless node.type.equal?(:numblock)
54+
emit_lambda_arguments
5555
else
5656
visit(target)
5757
end
@@ -63,7 +63,11 @@ def emit_send_target
6363
target_writer.emit_arguments_without_heredoc_body
6464
end
6565

66+
# NOTE: mutant fails on Ruby < 3.4
67+
# mutant:disable
6668
def emit_lambda_arguments
69+
return if node.type.equal?(:numblock) || itblock?
70+
6771
parentheses { writer_with(Args, node: arguments).emit_lambda_arguments }
6872
end
6973

test/corpus/literal/before/34.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
break or b
1717
next or b
1818
return or a
19-
20-
begin
21-
rescue => A[]
22-
end
2319
for foo[] in m do
2420
end
2521
for (a, b) in bar do

test/corpus/literal/rescue.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,7 @@
88
(foo = []) rescue nil
99
(foo = 1) rescue nil
1010
(foo = [1]) rescue nil
11+
12+
begin
13+
rescue => A[]
14+
end

test/corpus/semantic/itblock.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
x { it }
2+
3+
-> { it }

unparser.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Gem::Specification.new do |gem|
2727

2828
gem.add_dependency('diff-lcs', '~> 1.6')
2929
gem.add_dependency('parser', '>= 3.3.0')
30-
gem.add_dependency('prism', '>= 1.4')
30+
gem.add_dependency('prism', '>= 1.5.1')
3131

3232
gem.add_development_dependency('mutant', '~> 0.13.2')
3333
gem.add_development_dependency('mutant-rspec', '~> 0.13.0')

0 commit comments

Comments
 (0)