Stub SetHandleInformation/Socket::set_no_inherit

SetHandleInformation is exported by kernel32 on Win9X/ME, but is just
stubbed, returning `ERROR_CALL_NOT_IMPLEMENTED`. Sockets are
non-inheritable on these systems anyways, so we "fail successfully".
https://www.betaarchive.com/wiki/index.php/Microsoft_KB_Archive/150523#MORE_INFORMATION

SetHandleInformation is also unavailable on WinNT before 3.51. This is
fine, however, because MS did not supply WinSock 2 for Windows NT before
4.0, so this function is not called.

Author: seritools

library/std/src/os/windows/io/socket.rs

@@ -92,14 +92,27 @@ impl OwnedSocket {
     #[allow(fuzzy_provenance_casts)]
     #[cfg(not(target_vendor = "uwp"))]
     pub(crate) fn set_no_inherit(&self) -> io::Result<()> {
-        cvt(unsafe {
+        let res = cvt(unsafe {
             sys::c::SetHandleInformation(
                 self.as_raw_socket() as sys::c::HANDLE,
                 sys::c::HANDLE_FLAG_INHERIT,
                 0,
             )
         })
-        .map(drop)
+        .map(drop);
+
+        match res {
+            // SetHandleInformation is exported by kernel32 on Win9X/ME, but is just stubbed,
+            // returning `ERROR_CALL_NOT_IMPLEMENTED`. Sockets are non-inheritable on these
+            // systems anyways, so we "fail successfully" here.
+            // https://www.betaarchive.com/wiki/index.php/Microsoft_KB_Archive/150523#MORE_INFORMATION
+
+            // SetHandleInformation is also unavailable on WinNT before 3.51. This is fine,
+            // however, because MS did not supply WinSock 2 for Windows NT before 4.0, so this
+            // function is not called.
+            Err(e) if e.raw_os_error() == Some(sys::c::ERROR_CALL_NOT_IMPLEMENTED as i32) => Ok(()),
+            res => res,
+        }
     }
 
     #[cfg(target_vendor = "uwp")]

library/std/src/sys/windows/c.rs

@@ -493,6 +493,17 @@ compat_fn_with_fallback! {
         SetLastError(ERROR_CALL_NOT_IMPLEMENTED as DWORD);
         0
     }
+
+    // >= NT 3.51+
+    // https://docs.microsoft.com/en-us/windows/win32/api/handleapi/nf-handleapi-sethandleinformation
+    pub fn SetHandleInformation(
+        hObject: HANDLE,
+        dwMask: DWORD,
+        dwFlags: DWORD
+    ) -> BOOL {
+        SetLastError(ERROR_CALL_NOT_IMPLEMENTED as DWORD);
+        FALSE
+    }
 }
 
 compat_fn_optional! {

library/std/src/sys/windows/c/windows_sys.lst

@@ -1925,7 +1925,6 @@ Windows.Win32.Foundation.MAX_PATH
 Windows.Win32.Foundation.NO_ERROR
 Windows.Win32.Foundation.NTSTATUS
 Windows.Win32.Foundation.RtlNtStatusToDosError
-Windows.Win32.Foundation.SetHandleInformation
 Windows.Win32.Foundation.SetLastError
 Windows.Win32.Foundation.STATUS_DELETE_PENDING
 Windows.Win32.Foundation.STATUS_END_OF_FILE

library/std/src/sys/windows/c/windows_sys.rs

@@ -404,10 +404,6 @@ extern "system" {
     ) -> BOOL;
 }
 #[link(name = "kernel32")]
-extern "system" {
-    pub fn SetHandleInformation(hobject: HANDLE, dwmask: u32, dwflags: HANDLE_FLAGS) -> BOOL;
-}
-#[link(name = "kernel32")]
 extern "system" {
     pub fn SetLastError(dwerrcode: WIN32_ERROR) -> ();
 }