Skip to content
This repository was archived by the owner on Jun 10, 2018. It is now read-only.
This repository was archived by the owner on Jun 10, 2018. It is now read-only.

Opening in same BrowserWindow #32

@aguynamedben

Description

@aguynamedben

Hi, thank you for this excellent library. It helped me a ton. It's a great reference for how to do OAuth2 in Electron, and it works out of the box without any issues. I have it working very well with jsforce.

I was wondering if you had considered an option that would allow the current BrowserWindow to be used for OAuth2 sign in. Is there a fundamental reason that wouldn't work? A lot of users find the alwaysOnTop option of the new BrowserWindow annoying, especially if they use a password manager to store passwords or need to Cmd-Tab over to Messages to get a 2FA code).

I'd be interested in doing the work to support same-window OAuth2 if you could point me in the right direction. Thanks a lot again for this great library.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions