From aadabfbdc6ead67daf14648385bc1a2363b8db37 Mon Sep 17 00:00:00 2001 From: Don Gagne Date: Sun, 21 Sep 2025 09:24:40 -0700 Subject: [PATCH] Install nsis into github windows runner Used to be included automatically in runner but it was removed --- .github/workflows/windows.yml | 4 ++++ cmake/CreateWinInstaller.cmake | 1 + 2 files changed, 5 insertions(+) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 1276a1c7ac5b..b6bd9a997c27 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -69,6 +69,10 @@ jobs: with: version: ${{ env.GST_VERSION }} + - name: Install NSIS + run: choco install nsis -y + shell: powershell + - name: Setup Caching uses: ./.github/actions/cache with: diff --git a/cmake/CreateWinInstaller.cmake b/cmake/CreateWinInstaller.cmake index e568f616b507..fb6be7a62908 100644 --- a/cmake/CreateWinInstaller.cmake +++ b/cmake/CreateWinInstaller.cmake @@ -5,6 +5,7 @@ set(_PF86 "PROGRAMFILES(x86)") find_program(QGC_NSIS_INSTALLER_CMD makensis PATHS "$ENV{PROGRAMFILES}/NSIS" "$ENV{${_PF86}}/NSIS" "$ENV{PROGRAMW6432}/NSIS" DOC "Path to the makensis utility." + REQUIRED ) file(TO_NATIVE_PATH "${QGC_WINDOWS_ICON_PATH}" QGC_INSTALLER_ICON)