Add Go to confirmation option to Fly View settings

Added a Fly View setting to require confirmation for the "Go to
location" action when in Guided/Go To mode. This option can be disabled
to avoid overly frequent confirmation requests, as accidental triggers
are rare. A confirmation is always required if the vehicle is not
already in Guided/Go To mode. The option is enabled by default to match
the previous behavior behavior of always requiring confirmation.

Author: rubenp02

src/FlightDisplay/FlyViewMap.qml

@@ -702,7 +702,13 @@ FlightMap {
                         onClicked: {
                             mapClickDropPanel.close()
                             gotoLocationItem.show(mapClickCoord)
-                            globals.guidedControllerFlyView.confirmAction(globals.guidedControllerFlyView.actionGoto, mapClickCoord, gotoLocationItem)
+
+                            if ((_activeVehicle.flightMode == _activeVehicle.gotoFlightMode) && !_flyViewSettings.goToLocationRequiresConfirmInGuided.value) {
+                                globals.guidedControllerFlyView.executeAction(globals.guidedControllerFlyView.actionGoto, mapClickCoord, gotoLocationItem)
+                                gotoLocationItem.actionConfirmed() // Still need to call this to commit the new coordinate and radius
+                            } else {
+                                globals.guidedControllerFlyView.confirmAction(globals.guidedControllerFlyView.actionGoto, mapClickCoord, gotoLocationItem)
+                            }
                         }
                     }
 

src/Settings/FlyView.SettingsGroup.json

@@ -69,6 +69,12 @@
     "default":      80,
     "min":          25
 },
+{
+    "name":         "goToLocationRequiresConfirmInGuided",
+    "shortDesc":    "Require slide confirmation for Go To Location when the vehicle is already in Guided mode.",
+    "type":         "bool",
+    "default":      true
+},
 {
     "name":             "updateHomePosition",
     "shortDesc": "Send updated GCS' home position to autopilot in case of change of the home position",

src/Settings/FlyViewSettings.cc

@@ -23,6 +23,7 @@ DECLARE_SETTINGSFACT(FlyViewSettings, showAdditionalIndicatorsCompass)
 DECLARE_SETTINGSFACT(FlyViewSettings, lockNoseUpCompass)
 DECLARE_SETTINGSFACT(FlyViewSettings, maxGoToLocationDistance)
 DECLARE_SETTINGSFACT(FlyViewSettings, forwardFlightGoToLocationLoiterRad)
+DECLARE_SETTINGSFACT(FlyViewSettings, goToLocationRequiresConfirmInGuided)
 DECLARE_SETTINGSFACT(FlyViewSettings, keepMapCenteredOnVehicle)
 DECLARE_SETTINGSFACT(FlyViewSettings, showSimpleCameraControl)
 DECLARE_SETTINGSFACT(FlyViewSettings, showObstacleDistanceOverlay)

src/Settings/FlyViewSettings.h

@@ -26,6 +26,7 @@ class FlyViewSettings : public SettingsGroup
     DEFINE_SETTINGFACT(lockNoseUpCompass)
     DEFINE_SETTINGFACT(maxGoToLocationDistance)
     DEFINE_SETTINGFACT(forwardFlightGoToLocationLoiterRad)
+    DEFINE_SETTINGFACT(goToLocationRequiresConfirmInGuided)
     DEFINE_SETTINGFACT(keepMapCenteredOnVehicle)
     DEFINE_SETTINGFACT(showSimpleCameraControl)
     DEFINE_SETTINGFACT(showObstacleDistanceOverlay)

src/UI/preferences/FlyViewSettings.qml

@@ -36,6 +36,7 @@ SettingsPage {
     property Fact   _guidedMaximumAltitude:                 _flyViewSettings.guidedMaximumAltitude
     property Fact   _maxGoToLocationDistance:               _flyViewSettings.maxGoToLocationDistance
     property Fact   _forwardFlightGoToLocationLoiterRad:    _flyViewSettings.forwardFlightGoToLocationLoiterRad
+    property Fact   _goToLocationRequiresConfirmInGuided:   _flyViewSettings.goToLocationRequiresConfirmInGuided
     property var    _viewer3DSettings:                      _settingsManager.viewer3DSettings
     property Fact   _viewer3DEnabled:                       _viewer3DSettings.enabled
     property Fact   _viewer3DOsmFilePath:                   _viewer3DSettings.osmFilePath
@@ -117,7 +118,8 @@ SettingsPage {
         Layout.fillWidth:   true
         heading:            qsTr("Guided Commands")
         visible:            _guidedMinimumAltitude.visible || _guidedMaximumAltitude.visible ||
-                            _maxGoToLocationDistance.visible || _forwardFlightGoToLocationLoiterRad.visible
+                            _maxGoToLocationDistance.visible || _forwardFlightGoToLocationLoiterRad.visible ||
+                            _goToLocationRequiresConfirmInGuided.visible
 
         LabelledFactTextField {
             Layout.fillWidth:   true