fix: Running Migrations On Clean Installs #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where database migrations were running on clean Mautic installations, which could cause issues during the initial setup process. The fix adds a check to determine if Mautic is already installed before running migrations.
- Adds conditional logic to only run migrations when Mautic is already installed
- Introduces logging to track when migrations are run or skipped
- Uses the presence of
site_urlparameter in local.php as the installation indicator
|
@mautic/docker-maintainers could you please review this one? It's a blocker for 7.0.0-alpha |
2 tasks
matbcvo
reviewed
Aug 14, 2025
matbcvo
reviewed
Aug 14, 2025
Co-authored-by: Martin Vooremäe <martin.vooremae@gmail.com>
Co-authored-by: Martin Vooremäe <martin.vooremae@gmail.com>
|
Pipelines are going to fail. See #441 |
cibero42
changed the title
matbcvo
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #437, which was a bug introduced on #434, when trying to improve the upgrading process of the image.
Now migrations should only be ran when the container detects that Mautic is already installed, meaning, when local.php contains
parameters['site_url']