Set accessibility labels on the digit grouping segmented control

Author: mattrubin

Authenticator/Source/DisplayOptionsViewController.swift

@@ -114,7 +114,10 @@ extension DisplayOptionsViewController {
     fileprivate var digitGroupingRowViewModel: DigitGroupingRowViewModel<DisplayOptions.Effect> {
         return DigitGroupingRowViewModel(
             title: "Digit Grouping",
-            options: [(title: "•• •• ••", value: 2), (title: "••• •••", value: 3)],
+            options: [
+                (title: "•• •• ••", accessibilityLabel: "Groups of two digits", value: 2),
+                (title: "••• •••", accessibilityLabel: "Groups of three digits", value: 3),
+            ],
             value: viewModel.digitGroupSize,
             changeAction: DisplayOptions.Effect.setDigitGroupSize
         )
@@ -123,19 +126,21 @@ extension DisplayOptionsViewController {
 
 // MARK: Digit Grouping Row
 
+// swiftlint:disable large_tuple
 struct DigitGroupingRowViewModel<Action> {
     let title: String
-    let segments: [(title: String, action: Action)]
+    let segments: [(title: String, accessibilityLabel: String, action: Action)]
     let selectedSegmentIndex: Int?
 
-    init<V: Equatable>(title: String, options: [(title: String, value: V)], value: V, changeAction: (V) -> Action) {
+    init<V: Equatable>(title: String, options: [(title: String, accessibilityLabel: String, value: V)], value: V, changeAction: (V) -> Action) {
         self.title = title
         segments = options.map({ option in
-            (title: option.title, action: changeAction(option.value))
+            (title: option.title, accessibilityLabel: option.accessibilityLabel, action: changeAction(option.value))
         })
         selectedSegmentIndex = options.map({ $0.value }).index(of: value)
     }
 }
+// swiftlint:enable large_tuple
 
 class DigitGroupingRowCell<Action>: UITableViewCell {
     private let titleLabel = UILabel()
@@ -165,6 +170,8 @@ class DigitGroupingRowCell<Action>: UITableViewCell {
         titleLabel.translatesAutoresizingMaskIntoConstraints = false
         contentView.addSubview(titleLabel)
 
+        accessibilityHint = "The digits of a password can be shown in different sized groups."
+
         let font = UIFont.systemFont(ofSize: 40, weight: .light)
         let fontAttributes = [NSAttributedStringKey.font: font]
         segmentedControl.setTitleTextAttributes(fontAttributes, for: .normal)
@@ -213,6 +220,10 @@ class DigitGroupingRowCell<Action>: UITableViewCell {
         for i in viewModel.segments.indices {
             let segment = viewModel.segments[i]
             segmentedControl.insertSegment(withTitle: segment.title, at: i, animated: false)
+
+            // This is a hack to set the accessibility label on each segment, but for now it works.
+            // If a future iOS update ever changes the internals of UISegmentedControl, this may break horribly.
+            segmentedControl.subviews.last?.accessibilityLabel = segment.accessibilityLabel
         }
         // Store the action associated with each segment
         actions = viewModel.segments.map({ $0.action })