Limit scanning (not haptic feedback) to one result per second

Author: mattrubin

Authenticator/Source/AppController.swift

@@ -53,7 +53,6 @@ class AppController {
             dispatchAction: self.handleAction
         )
     }()
-    private var lastHapticFeedback = Date(timeIntervalSince1970: 0)
 
     init() {
         do {
@@ -202,12 +201,8 @@ class AppController {
     // Provide haptic feedback to accompany success and error messages
     private func generateFeedback(for notificationFeedbackType: UINotificationFeedbackType) {
         if #available(iOS 10.0, *) {
-            let now = Date()
-            if now.timeIntervalSince(lastHapticFeedback) > 1 {
-                lastHapticFeedback = now
-                let feedbackGenerator = UINotificationFeedbackGenerator()
-                feedbackGenerator.notificationOccurred(notificationFeedbackType)
-            }
+            let feedbackGenerator = UINotificationFeedbackGenerator()
+            feedbackGenerator.notificationOccurred(notificationFeedbackType)
         }
     }
 

Authenticator/Source/TokenScannerViewController.swift

@@ -184,10 +184,18 @@ final class TokenScannerViewController: UIViewController, QRScannerDelegate {
 
     // MARK: QRScannerDelegate
 
+    private var lastScanTime = Date(timeIntervalSince1970: 0)
+    private let minimumScanInterval: TimeInterval = 1
+
     func handleDecodedText(_ text: String) {
         guard viewModel.isScanning else {
             return
         }
-        dispatchAction(.scannerDecodedText(text))
+
+        let now = Date()
+        if now.timeIntervalSince(lastScanTime) > minimumScanInterval {
+            lastScanTime = now
+            dispatchAction(.scannerDecodedText(text))
+        }
     }
 }