[lint] Enable several new SwiftLint opt-in rules

Author: mattrubin

.swiftlint.yml

@@ -13,6 +13,7 @@ opt_in_rules:
   - discouraged_object_literal
   - discouraged_optional_boolean
   - empty_count
+  - empty_string
   - explicit_enum_raw_value
   - explicit_init
   - extension_access_modifier
@@ -25,6 +26,7 @@ opt_in_rules:
   - joined_default_parameter
   - let_var_whitespace
   - literal_expression_end_indentation
+  - lower_acl_than_parent
   - operator_usage_whitespace
   - overridden_super_call
   - override_in_extension
@@ -36,6 +38,7 @@ opt_in_rules:
   - single_test_class
   - sorted_first_last
   - switch_case_on_newline
+  - untyped_error_in_catch
   - vertical_parameter_alignment_on_call
   - yoda_condition
 disabled_rules:

Authenticator/Source/RootViewController.swift

@@ -194,7 +194,7 @@ private func compose<A, B, C>(_ transform: @escaping (A) -> B, _ handler: @escap
 }
 
 extension RootViewController: UINavigationControllerDelegate {
-    public func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
+    func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
         if case .info(_, .some) = currentViewModel.modal,
             viewController is InfoListViewController {
             // If the view model modal state has an Info.ViewModel and the just-shown view controller is an info list,