Merge pull request #294 from mattrubin/tools

mattrubin · web-flow · commit 6b007fe7aedc · 2018-09-27T19:49:04.000-04:00
Update tool configuration
diff --git a/.codecov.yml b/.codecov.yml
@@ -7,6 +7,8 @@ codecov:
 ignore:
   - AuthenticatorTests
 
+comment: off # Disable coverage comments on pull requests
+
 coverage:
   status:
     project:
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -10,13 +10,16 @@ opt_in_rules:
   - closure_spacing
   - conditional_returns_on_newline
   - contains_over_first_not_nil
+  - convenience_type
   - discouraged_object_literal
   - discouraged_optional_boolean
   - empty_count
   - empty_string
+  - empty_xctest_method
   - explicit_enum_raw_value
   - explicit_init
   - extension_access_modifier
+  - fallthrough
   - fatal_error_message
   - file_header
   - first_where
@@ -27,6 +30,8 @@ opt_in_rules:
   - let_var_whitespace
   - literal_expression_end_indentation
   - lower_acl_than_parent
+  - modifier_order
+  - multiline_function_chains
   - operator_usage_whitespace
   - overridden_super_call
   - override_in_extension
@@ -35,9 +40,11 @@ opt_in_rules:
   - private_outlet
   - prohibited_super_call
   - redundant_nil_coalescing
+  - redundant_type_annotation
   - single_test_class
   - sorted_first_last
   - switch_case_on_newline
+  - unavailable_function
   - untyped_error_in_catch
   - vertical_parameter_alignment_on_call
   - yoda_condition
diff --git a/Authenticator/Source/Colors.swift b/Authenticator/Source/Colors.swift
@@ -2,7 +2,7 @@
 //  Colors.swift
 //  Authenticator
 //
-//  Copyright (c) 2014-2017 Authenticator authors
+//  Copyright (c) 2014-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
@@ -36,7 +36,7 @@ extension UIColor {
         )
     }
 
-    private struct OTP {
+    private enum OTP {
         static let darkColor = UIColor(red: 35, green: 35, blue: 50)
         static let lightColor = UIColor(red: 250, green: 248, blue: 240)
     }
diff --git a/Authenticator/Source/DisplayOptionsViewController.swift b/Authenticator/Source/DisplayOptionsViewController.swift
@@ -37,6 +37,7 @@ final class DisplayOptionsViewController: UITableViewController {
         super.init(nibName: nil, bundle: nil)
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/Authenticator/Source/InfoListViewController.swift b/Authenticator/Source/InfoListViewController.swift
@@ -37,6 +37,7 @@ final class InfoListViewController: UITableViewController {
         super.init(nibName: nil, bundle: nil)
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/Authenticator/Source/InfoViewController.swift b/Authenticator/Source/InfoViewController.swift
@@ -2,7 +2,7 @@
 //  InfoViewController.swift
 //  Authenticator
 //
-//  Copyright (c) 2017 Authenticator authors
+//  Copyright (c) 2017-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
@@ -40,6 +40,7 @@ final class InfoViewController: UIViewController, WKNavigationDelegate {
         super.init(nibName: nil, bundle: nil)
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/Authenticator/Source/QRScanner.swift b/Authenticator/Source/QRScanner.swift
@@ -2,7 +2,7 @@
 //  QRScanner.swift
 //  Authenticator
 //
-//  Copyright (c) 2015-2017 Authenticator authors
+//  Copyright (c) 2015-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
diff --git a/Authenticator/Source/RootViewController.swift b/Authenticator/Source/RootViewController.swift
@@ -67,6 +67,7 @@ class RootViewController: OpaqueNavigationController {
         self.viewControllers = [tokenListViewController]
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/Authenticator/Source/TokenFormViewController.swift b/Authenticator/Source/TokenFormViewController.swift
@@ -55,6 +55,7 @@ final class TokenFormViewController<Form: TableViewModelRepresentable>: UITableV
         super.init(style: .grouped)
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/Authenticator/Source/TokenListViewController.swift b/Authenticator/Source/TokenListViewController.swift
@@ -2,7 +2,7 @@
 //  TokenListViewController.swift
 //  Authenticator
 //
-//  Copyright (c) 2013-2017 Authenticator authors
+//  Copyright (c) 2013-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
@@ -36,6 +36,7 @@ class TokenListViewController: UITableViewController {
         super.init(nibName: nil, bundle: nil)
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/Authenticator/Source/TokenScannerViewController.swift b/Authenticator/Source/TokenScannerViewController.swift
@@ -2,7 +2,7 @@
 //  TokenScannerViewController.swift
 //  Authenticator
 //
-//  Copyright (c) 2013-2017 Authenticator authors
+//  Copyright (c) 2013-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
@@ -78,6 +78,7 @@ final class TokenScannerViewController: UIViewController, QRScannerDelegate {
         super.init(nibName: nil, bundle: nil)
     }
 
+    @available(*, unavailable)
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
diff --git a/AuthenticatorTests/RootTests.swift b/AuthenticatorTests/RootTests.swift
@@ -2,7 +2,7 @@
 //  RootTests.swift
 //  Authenticator
 //
-//  Copyright (c) 2017 Authenticator authors
+//  Copyright (c) 2017-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
diff --git a/AuthenticatorTests/TableDiffTests.swift b/AuthenticatorTests/TableDiffTests.swift
@@ -2,7 +2,7 @@
 //  TableDiffTests.swift
 //  Authenticator
 //
-//  Copyright (c) 2016-2017 Authenticator authors
+//  Copyright (c) 2016-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
diff --git a/AuthenticatorTests/TokenListTests.swift b/AuthenticatorTests/TokenListTests.swift
@@ -2,7 +2,7 @@
 //  TokenListTests.swift
 //  Authenticator
 //
-//  Copyright (c) 2016-2017 Authenticator authors
+//  Copyright (c) 2016-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
diff --git a/AuthenticatorTests/TokenScannerTests.swift b/AuthenticatorTests/TokenScannerTests.swift
@@ -2,7 +2,7 @@
 //  TokenScannerTests.swift
 //  Authenticator
 //
-//  Copyright (c) 2017 Authenticator authors
+//  Copyright (c) 2017-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal
diff --git a/AuthenticatorTests/UITableViewUpdateTests.swift b/AuthenticatorTests/UITableViewUpdateTests.swift
@@ -2,7 +2,7 @@
 //  UITableViewUpdateTests.swift
 //  Authenticator
 //
-//  Copyright (c) 2017 Authenticator authors
+//  Copyright (c) 2017-2018 Authenticator authors
 //
 //  Permission is hereby granted, free of charge, to any person obtaining a copy
 //  of this software and associated documentation files (the "Software"), to deal

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`// Colors.swift`
`3`	`3`	`// Authenticator`
`4`	`4`	`//`
`5`		`-// Copyright (c) 2014-2017 Authenticator authors`
	`5`	`+// Copyright (c) 2014-2018 Authenticator authors`
`6`	`6`	`//`
`7`	`7`	`// Permission is hereby granted, free of charge, to any person obtaining a copy`
`8`	`8`	`// of this software and associated documentation files (the "Software"), to deal`
`@@ -36,7 +36,7 @@ extension UIColor {`
`36`	`36`	`)`
`37`	`37`	`}`
`38`	`38`
`39`		`- private struct OTP {`
	`39`	`+ private enum OTP {`
`40`	`40`	`static let darkColor = UIColor(red: 35, green: 35, blue: 50)`
`41`	`41`	`static let lightColor = UIColor(red: 250, green: 248, blue: 240)`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ final class DisplayOptionsViewController: UITableViewController {`
`37`	`37`	`super.init(nibName: nil, bundle: nil)`
`38`	`38`	`}`
`39`	`39`
	`40`	`+ @available(*, unavailable)`
`40`	`41`	`required init?(coder aDecoder: NSCoder) {`
`41`	`42`	`fatalError("init(coder:) has not been implemented")`
`42`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ final class InfoListViewController: UITableViewController {`
`37`	`37`	`super.init(nibName: nil, bundle: nil)`
`38`	`38`	`}`
`39`	`39`
	`40`	`+ @available(*, unavailable)`
`40`	`41`	`required init?(coder aDecoder: NSCoder) {`
`41`	`42`	`fatalError("init(coder:) has not been implemented")`
`42`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ class RootViewController: OpaqueNavigationController {`
`67`	`67`	`self.viewControllers = [tokenListViewController]`
`68`	`68`	`}`
`69`	`69`
	`70`	`+ @available(*, unavailable)`
`70`	`71`	`required init?(coder aDecoder: NSCoder) {`
`71`	`72`	`fatalError("init(coder:) has not been implemented")`
`72`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@ final class TokenFormViewController<Form: TableViewModelRepresentable>: UITableV`
`55`	`55`	`super.init(style: .grouped)`
`56`	`56`	`}`
`57`	`57`
	`58`	`+ @available(*, unavailable)`
`58`	`59`	`required init?(coder aDecoder: NSCoder) {`
`59`	`60`	`fatalError("init(coder:) has not been implemented")`
`60`	`61`	`}`