Improve VoiceOver navigation for text field rows

mattrubin · mattrubin · commit 5d09cb084116 · 2017-11-18T14:42:18.000-05:00
diff --git a/Authenticator/Source/TextFieldRow.swift b/Authenticator/Source/TextFieldRow.swift
@@ -73,6 +73,8 @@ class TextFieldRowCell<Action>: UITableViewCell, UITextFieldDelegate {
         textField.borderStyle = .roundedRect
         textField.font = UIFont.systemFont(ofSize: 16, weight: UIFontWeightLight)
         contentView.addSubview(textField)
+
+        accessibilityElements = [textField]
     }
 
     override func layoutSubviews() {
@@ -101,6 +103,8 @@ class TextFieldRowCell<Action>: UITableViewCell, UITextFieldDelegate {
             textField.text = viewModel.value
         }
         changeAction = viewModel.changeAction
+
+        textField.accessibilityLabel = viewModel.label
     }
 
     static func heightWithViewModel(_ viewModel: TextFieldRowViewModel<Action>) -> CGFloat {

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ class TextFieldRowCell<Action>: UITableViewCell, UITextFieldDelegate {`
`73`	`73`	`textField.borderStyle = .roundedRect`
`74`	`74`	`textField.font = UIFont.systemFont(ofSize: 16, weight: UIFontWeightLight)`
`75`	`75`	`contentView.addSubview(textField)`
	`76`	`+`
	`77`	`+ accessibilityElements = [textField]`
`76`	`78`	`}`
`77`	`79`
`78`	`80`	`override func layoutSubviews() {`
`@@ -101,6 +103,8 @@ class TextFieldRowCell<Action>: UITableViewCell, UITextFieldDelegate {`
`101`	`103`	`textField.text = viewModel.value`
`102`	`104`	`}`
`103`	`105`	`changeAction = viewModel.changeAction`
	`106`	`+`
	`107`	`+ textField.accessibilityLabel = viewModel.label`
`104`	`108`	`}`
`105`	`109`
`106`	`110`	`static func heightWithViewModel(_ viewModel: TextFieldRowViewModel<Action>) -> CGFloat {`