Speed up -testTokenWithURLAndSecret by removing one nested loop

Author: mattrubin

AuthenticatorTests/OTPTokenSerializationTests.m

@@ -144,12 +144,11 @@ - (void)testTokenWithURLAndSecret
                     for (NSNumber *digitNumber in digitNumbers) {
                         for (NSNumber *periodNumber in periodNumbers) {
                             for (NSNumber *counterNumber in counterNumbers) {
-                                for (NSString *secondSecretString in secretStrings) {
                                     // Construct the URL
                                     NSMutableDictionary *query = [NSMutableDictionary dictionary];
                                     query[@"algorithm"] = [NSString stringForAlgorithm:[algorithmNumber unsignedIntValue]];
                                     query[@"digits"] = digitNumber;
-                                    query[@"secret"] = [[[secretString dataUsingEncoding:NSASCIIStringEncoding] base32String] stringByReplacingOccurrencesOfString:@"=" withString:@""];
+                                    query[@"secret"] = @"A";
                                     query[@"period"] = [periodNumber isEqual:kRandomKey] ? @(arc4random()%299 + 1) : periodNumber;
                                     query[@"counter"] = [counterNumber isEqual:kRandomKey] ? @(arc4random() + ((uint64_t)arc4random() << 32)) : counterNumber;
                                     if (![issuer isEqual:[NSNull null]])
@@ -163,7 +162,7 @@ - (void)testTokenWithURLAndSecret
                                     urlComponents.percentEncodedQuery = [query queryString];
 
                                     // Create the token
-                                    NSData *secret = [secondSecretString dataUsingEncoding:NSASCIIStringEncoding];
+                                    NSData *secret = [secretString dataUsingEncoding:NSASCIIStringEncoding];
                                     OTPToken *token = [OTPToken tokenWithURL:[urlComponents URL] secret:secret];
 
                                     // Note: [OTPToken tokenWithURL:] will return nil if the token described by the URL is invalid.
@@ -197,7 +196,6 @@ - (void)testTokenWithURLAndSecret
                 }
             }
         }
-        }
     }
 }