Release Authenticator 2.0.1

Author: mattrubin

.travis.yml

@@ -5,28 +5,25 @@ language: objective-c
 xcode_workspace: Authenticator.xcworkspace
 xcode_scheme: Authenticator
 
-osx_image: xcode8.3
+osx_image: xcode9
 
 env:
   - RUNTIME="iOS 9.0"  DEVICE="iPhone 4s"
-  - RUNTIME="iOS 9.1"  DEVICE="iPhone 5"
-  - RUNTIME="iOS 9.2"  DEVICE="iPhone 5s"
   - RUNTIME="iOS 9.3"  DEVICE="iPhone 6s"
-  - RUNTIME="iOS 10.0" DEVICE="iPhone 6s Plus"
-  - RUNTIME="iOS 10.1" DEVICE="iPhone SE"
-  - RUNTIME="iOS 10.2" DEVICE="iPhone 7"
+  - RUNTIME="iOS 10.0" DEVICE="iPhone SE"
   - RUNTIME="iOS 10.3" DEVICE="iPhone 7 Plus"
+  - RUNTIME="iOS 11.0" DEVICE="iPhone X"
 
 install:
   - git submodule update --init --recursive
 
 before_script:
-- DEVICE_ID=com.apple.CoreSimulator.SimDeviceType.$(echo $DEVICE | sed -E -e "s/[ \-]+/ /g" -e "s/[^[:alnum:]]/-/g")
-- RUNTIME_ID=com.apple.CoreSimulator.SimRuntime.$(echo $RUNTIME | sed -E -e "s/[ \-]+/ /g" -e "s/[^[:alnum:]]/-/g")
-- DESTINATION_ID=$(xcrun simctl create Travis $DEVICE_ID $RUNTIME_ID)
-- xcrun simctl boot $DESTINATION_ID
+  - DEVICE_ID=com.apple.CoreSimulator.SimDeviceType.$(echo $DEVICE | sed -E -e "s/[ \-]+/ /g" -e "s/[^[:alnum:]]/-/g")
+  - RUNTIME_ID=com.apple.CoreSimulator.SimRuntime.$(echo $RUNTIME | sed -E -e "s/[ \-]+/ /g" -e "s/[^[:alnum:]]/-/g")
+  - DESTINATION_ID=$(xcrun simctl create Travis $DEVICE_ID $RUNTIME_ID)
+  - xcrun simctl boot $DESTINATION_ID
 
-script: set -o pipefail && xcodebuild -workspace "$TRAVIS_XCODE_WORKSPACE" -scheme "$TRAVIS_XCODE_SCHEME" -destination "id=$DESTINATION_ID" build test | xcpretty -c
+script: set -o pipefail && xcodebuild -workspace "$TRAVIS_XCODE_WORKSPACE" -scheme "$TRAVIS_XCODE_SCHEME" -destination "id=$DESTINATION_ID" build-for-testing test-without-building | xcpretty -c
 
 after_success:
   - bash <(curl -s https://codecov.io/bash)

Authenticator.xcodeproj/project.pbxproj

@@ -740,11 +740,13 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				BUNDLE_DISPLAY_NAME = "${PRODUCT_NAME} ∆";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
+				CURRENT_PROJECT_VERSION = 0;
 				DEVELOPMENT_TEAM = WD7ETSN9J9;
 				INFOPLIST_FILE = Authenticator/Resources/Info.plist;
 				PRODUCT_BUNDLE_IDENTIFIER = me.mattrubin.authenticator.dev;
 				PRODUCT_NAME = Authenticator;
 				TARGETED_DEVICE_FAMILY = 1;
+				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Debug;
 		};
@@ -755,11 +757,13 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				BUNDLE_DISPLAY_NAME = "${PRODUCT_NAME}";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
+				CURRENT_PROJECT_VERSION = 0;
 				DEVELOPMENT_TEAM = WD7ETSN9J9;
 				INFOPLIST_FILE = Authenticator/Resources/Info.plist;
 				PRODUCT_BUNDLE_IDENTIFIER = me.mattrubin.authenticator;
 				PRODUCT_NAME = Authenticator;
 				TARGETED_DEVICE_FAMILY = 1;
+				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Release;
 		};

Authenticator/Resources/GenerateIcons.sh

@@ -27,6 +27,7 @@ inkscape -z -e "${ICONSET}/Icon-120.png" -w 120 $ICON_SVG;
 inkscape -z -e "${ICONSET}/Icon-152.png" -w 152 $ICON_SVG;
 inkscape -z -e "${ICONSET}/Icon-167.png" -w 167 $ICON_SVG;
 inkscape -z -e "${ICONSET}/Icon-180.png" -w 180 $ICON_SVG;
+inkscape -z -e "${ICONSET}/Icon-1024.png" -w 1024 $ICON_SVG;
 
 for ICON in $ICONSET/Icon-*.png; do
   pngcrush -rem alla -ow -res 144 $ICON;

Authenticator/Resources/Images.xcassets/AppIcon.appiconset/Contents.json

@@ -101,6 +101,12 @@
       "idiom" : "ipad",
       "filename" : "Icon-167.png",
       "scale" : "2x"
+    },
+    {
+      "size" : "1024x1024",
+      "idiom" : "ios-marketing",
+      "filename" : "Icon-1024.png",
+      "scale" : "1x"
     }
   ],
   "info" : {

Authenticator/Resources/Images.xcassets/AppIcon.appiconset/Icon-1024.png

@@ -17,7 +17,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>2.0.0</string>
+	<string>2.0.1</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleURLTypes</key>

Authenticator/Resources/Info.plist

@@ -57,7 +57,7 @@ class ButtonHeaderView<Action>: UIButton {
 
     private func configureSubviews() {
         titleLabel?.textAlignment = .center
-        titleLabel?.textColor = UIColor.otpForegroundColor
+        setTitleColor(.otpForegroundColor, for: UIControlState.normal)
         titleLabel?.font = UIFont.systemFont(ofSize: 16, weight: UIFontWeightLight)
 
         addTarget(self, action: #selector(ButtonHeaderView.buttonWasPressed), for: .touchUpInside)

Authenticator/Source/ButtonHeaderView.swift

@@ -34,8 +34,17 @@ class OTPAppDelegate: UIResponder, UIApplicationDelegate {
     let app = AppController()
 
     func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
-        let barButtonAttributes = [NSFontAttributeName: UIFont.systemFont(ofSize: 17, weight: UIFontWeightLight)]
-        UIBarButtonItem.appearance().setTitleTextAttributes(barButtonAttributes, for: .normal)
+        let barButtonItemFont = UIFont.systemFont(ofSize: 17, weight: UIFontWeightLight)
+        let fontAttributes = [NSFontAttributeName: barButtonItemFont]
+        UIBarButtonItem.appearance().setTitleTextAttributes(fontAttributes, for: .normal)
+        UIBarButtonItem.appearance().setTitleTextAttributes(fontAttributes, for: .highlighted)
+        UIBarButtonItem.appearance().setTitleTextAttributes(fontAttributes, for: .selected)
+
+        let disabledAttributes = [
+            NSFontAttributeName: barButtonItemFont,
+            NSForegroundColorAttributeName: UIColor.otpBarForegroundColor.withAlphaComponent(0.3),
+        ]
+        UIBarButtonItem.appearance().setTitleTextAttributes(disabledAttributes, for: .disabled)
 
         // Restore white-on-black style
         SVProgressHUD.setForegroundColor(.otpLightColor)

Authenticator/Source/OTPAppDelegate.swift

@@ -250,6 +250,15 @@ extension TokenListViewController {
     override func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
         return 85
     }
+
+    override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
+        let rowModel = viewModel.rowModels[indexPath.row]
+        if isEditing {
+            dispatchAction(rowModel.editAction)
+        } else {
+            dispatchAction(rowModel.selectAction)
+        }
+    }
 }
 
 // MARK: TokenListPresenter

Authenticator/Source/TokenListViewController.swift

@@ -140,18 +140,6 @@ class TokenRowCell: UITableViewCell {
 
     // MARK: - Actions
 
-    override func setSelected(_ selected: Bool, animated: Bool) {
-        super.setSelected(selected, animated: animated)
-
-        if selected, let rowModel = rowModel {
-            if self.isEditing {
-                dispatchAction?(rowModel.editAction)
-            } else {
-                dispatchAction?(rowModel.selectAction)
-            }
-        }
-    }
-
     func generateNextPassword() {
         if let action = rowModel?.buttonAction {
             dispatchAction?(action)