From 44b34b17000b6d62d133a3adf315d6205260167f Mon Sep 17 00:00:00 2001 From: Morgan Larosa Date: Wed, 26 Oct 2022 14:18:29 +1100 Subject: [PATCH 1/2] Fix Windows installation when username has space in it - Modify run_unzip.cmd to wrap invocations and paths in quotes - This prevents issues where a user's home directory has spaces in it due to their username, such as 'C:\Users\FirstName LastName', from causing commands to fail because they parse the different parts of the path as separate arguments. --- installer/run_unzip.cmd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/installer/run_unzip.cmd b/installer/run_unzip.cmd index 341cb233..7d594c55 100644 --- a/installer/run_unzip.cmd +++ b/installer/run_unzip.cmd @@ -4,8 +4,8 @@ if "x%1" equ "x" goto :EOF where unzip 2>NUL if %ERRORLEVEL% equ 0 ( - unzip %* + unzip "%*" ) else ( - curl -L -o %~dp0\unzip.exe https://github.com/mattn/vim-lsp-settings/releases/download/v0.0.1/unzip.exe - %~dp0\unzip %* + curl -L -o "%~dp0\unzip.exe" https://github.com/mattn/vim-lsp-settings/releases/download/v0.0.1/unzip.exe + "%~dp0\unzip" "%*" ) From 1c2fe64d42803bd0b9e05a6af450d54b58598c4e Mon Sep 17 00:00:00 2001 From: Morgan Larosa Date: Wed, 26 Oct 2022 14:26:01 +1100 Subject: [PATCH 2/2] Fix Windows installation space handling some more - This change applies the same fix to run_gzip.cmd as the previous commit. --- installer/run_gzip.cmd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/installer/run_gzip.cmd b/installer/run_gzip.cmd index 549b0f6b..0db6e527 100644 --- a/installer/run_gzip.cmd +++ b/installer/run_gzip.cmd @@ -2,8 +2,8 @@ where gzip 2>NUL if %ERRORLEVEL% equ 0 ( - gzip -d %* + gzip -d "%*" ) else ( - curl -L -o %~dp0\busybox.exe https://github.com/mattn/vim-lsp-settings/releases/download/v0.0.1/busybox.exe - %~dp0\busybox gzip -d %* + curl -L -o "%~dp0\busybox.exe" https://github.com/mattn/vim-lsp-settings/releases/download/v0.0.1/busybox.exe + "%~dp0\busybox" gzip -d "%*" )