refactor(ffi): simplify From<TimelineDetails<Profile>> for ProfileDetails

Author: bnjbvr

bindings/matrix-sdk-ffi/src/timeline/mod.rs

@@ -692,7 +692,7 @@ impl Timeline {
                 EmbeddedEventDetails::Ready {
                     content: replied_to.content.clone().into(),
                     sender: replied_to.sender.to_string(),
-                    sender_profile: (&replied_to.sender_profile).into(),
+                    sender_profile: replied_to.sender_profile.into(),
                 },
             ))),
 
@@ -1103,7 +1103,7 @@ impl From<matrix_sdk_ui::timeline::EventTimelineItem> for EventTimelineItem {
             is_remote: !item.is_local_echo(),
             event_or_transaction_id: item.identifier().into(),
             sender: item.sender().to_string(),
-            sender_profile: item.sender_profile().into(),
+            sender_profile: item.sender_profile().clone().into(),
             is_own: item.is_own(),
             is_editable: item.is_editable(),
             content: item.content().clone().into(),
@@ -1144,14 +1144,13 @@ pub enum ProfileDetails {
     Error { message: String },
 }
 
-// TODO try to !use &
-impl From<&TimelineDetails<Profile>> for ProfileDetails {
-    fn from(details: &TimelineDetails<Profile>) -> Self {
+impl From<TimelineDetails<Profile>> for ProfileDetails {
+    fn from(details: TimelineDetails<Profile>) -> Self {
         match details {
             TimelineDetails::Unavailable => Self::Unavailable,
             TimelineDetails::Pending => Self::Pending,
             TimelineDetails::Ready(profile) => Self::Ready {
-                display_name: profile.display_name.clone(),
+                display_name: profile.display_name,
                 display_name_ambiguous: profile.display_name_ambiguous,
                 avatar_url: profile.avatar_url.as_ref().map(ToString::to_string),
             },

bindings/matrix-sdk-ffi/src/timeline/reply.rs

@@ -62,7 +62,7 @@ impl From<TimelineDetails<Box<EmbeddedEvent>>> for EmbeddedEventDetails {
             TimelineDetails::Ready(event) => EmbeddedEventDetails::Ready {
                 content: event.content.into(),
                 sender: event.sender.to_string(),
-                sender_profile: (&event.sender_profile).into(),
+                sender_profile: event.sender_profile.into(),
             },
             TimelineDetails::Error(err) => EmbeddedEventDetails::Error { message: err.to_string() },
         }