-
-
Notifications
You must be signed in to change notification settings - Fork 624
RTCEncryptionManager: Joiner key rotation grace period #4911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BillCarsonFr
merged 14 commits into
develop
from
valere/rtc/encryption_mgr/rotate_joiner_with_grace
Jul 18, 2025
+276
−59
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1d798cb
RTCEncryptionManager: Joiner key rotation grace period
BillCarsonFr 0bda8e0
Test to clarify useKeyDelay and keyRotationGracePeriodMs interference
BillCarsonFr a23c629
Merge branch 'develop' into valere/rtc/encryption_mgr/rotate_joiner_w…
BillCarsonFr 46f3e89
Merge branch 'develop' into valere/rtc/encryption_mgr/rotate_joiner_w…
BillCarsonFr 966d9b9
make test more configurable
BillCarsonFr 65e5003
rename delayRolloutTimeMillis to useKeyDelay same as config option
BillCarsonFr efd6f0b
rename skipRotationGracePeriod to keyRotationGracePeriodMs
BillCarsonFr 6d06e24
clarify that oldMemberships is not used by RTCEncryptionManager
BillCarsonFr 615e3fd
improve doc
BillCarsonFr 6a93812
cleanup test
BillCarsonFr 31b2e0b
more comment in test
BillCarsonFr 5dc032c
comment additions
toger5 82fffea
cleanup runOnlyPendingTimers
toger5 1ff8095
Merge branch 'develop' into valere/rtc/encryption_mgr/rotate_joiner_w…
toger5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.