Merge pull request #71 from StefRe/fix/nan-warning

Suppress warning 'invalid value encountered in sign'

Author: phobson

probscale/probscale.py

@@ -1,4 +1,5 @@
 import numpy
+import warnings
 from matplotlib.scale import ScaleBase
 from matplotlib.ticker import (
     FixedLocator,
@@ -29,7 +30,9 @@ def _approx_erf(cls, x):
         """
 
         guts = -x**2 * (4.0 / numpy.pi + cls._A * x**2) / (1.0 + cls._A * x**2)
-        return numpy.sign(x) * numpy.sqrt(1.0 - numpy.exp(guts))
+        with warnings.catch_warnings():
+            warnings.filterwarnings('ignore', 'invalid value encountered in sign')
+            return numpy.sign(x) * numpy.sqrt(1.0 - numpy.exp(guts))
 
     @classmethod
     def _approx_inv_erf(cls, z):
@@ -41,7 +44,9 @@ def _approx_inv_erf(cls, z):
 
         _b = (2 / numpy.pi / cls._A) + (0.5 * numpy.log(1 - z**2))
         _c = numpy.log(1 - z**2) / cls._A
-        return numpy.sign(z) * numpy.sqrt(numpy.sqrt(_b**2 - _c) - _b)
+        with warnings.catch_warnings():
+            warnings.filterwarnings('ignore', 'invalid value encountered in sign')
+            return numpy.sign(z) * numpy.sqrt(numpy.sqrt(_b**2 - _c) - _b)
 
     @classmethod
     def ppf(cls, q):

probscale/tests/test_probscale.py

@@ -72,6 +72,20 @@ def test_minimal_norm_cdf(mn, mn_input):
     assert numpy.all(numpy.abs(diff) < 0.001)
 
 
+def test_sign_with_nan_no_warning(mn):
+    with pytest.warns(None) as record:
+        res = mn._approx_erf(numpy.nan)
+    assert not record
+    assert numpy.isnan(res)
+
+
+def test_sign_with_nan_no_warning(mn):
+    with pytest.warns(None) as record:
+        res = mn._approx_inv_erf(numpy.nan)
+    assert not record
+    assert numpy.isnan(res)
+
+
 @pytest.mark.mpl_image_compare(
     baseline_dir='baseline_images/test_probscale',
     tolerance=TOLERANCE,