Skip to content

Chapter 15 says OLS but it isn't OLS, it's regularised #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ellisp opened this issue Sep 23, 2024 · 0 comments
Open

Chapter 15 says OLS but it isn't OLS, it's regularised #414

ellisp opened this issue Sep 23, 2024 · 0 comments
Assignees

Comments

@ellisp
Copy link

ellisp commented Sep 23, 2024

There is an issue on chapter 15, in the following paragraph

To do this with linear regression, we will find the weight using OLS. We will minimise the square distance between the weighted average of the units in the donor pool and the treated unit for the pre-intervention period.

In fact, OLS wouldn't work because you have 38 states and only 19 years. You use the default sklearn.linear_model, which applies regularization by default. If you don't know this, it probably means that a lot of the time you think you are doing OLS you actually are getting estimates that have been shrunk to zero instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants