Merge branch 'release-candidate' into stable

Jeff Verkoeyen · Jeff Verkoeyen · commit c3f720c0838a · 2018-12-21T08:58:48.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 3.0.0
+
+`unused-parameter` has been disabled because it can cause release builds to fail to build when
+using debug-only assertions to check parameters.
+
 # 2.0.0
 
 Added additional warnings to `strict_warnings_objc_library`:
diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ Add the following to your `WORKSPACE`:
 git_repository(
     name = "bazel_ios_warnings",
     remote = "https://github.com/material-foundation/bazel_ios_warnings.git",
-    tag = "v2.0.0",
+    tag = "v3.0.0",
 )
 ```
 
diff --git a/strict_warnings_objc_library.bzl b/strict_warnings_objc_library.bzl
@@ -39,6 +39,7 @@ COMMON_COPTS = [
     "-Wunused-variable",
     "-Wunused-volatile-lvalue",
     "-Wused-but-marked-unused",
+    "-Wno-unused-parameter",  # Enabled by -Wall via -Wunused, problems with params used in asserts.
 ]
 
 def strict_warnings_objc_library(

Original file line number	Diff line number	Diff line change
@@ -9,7 +9,7 @@ Add the following to your `WORKSPACE`:
`9`	`9`	`git_repository(`
`10`	`10`	`name = "bazel_ios_warnings",`
`11`	`11`	`remote = "https://github.com/material-foundation/bazel_ios_warnings.git",`
`12`		`- tag = "v2.0.0",`
	`12`	`+ tag = "v3.0.0",`
`13`	`13`	`)`
`14`	`14`	```
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ COMMON_COPTS = [`
`39`	`39`	`"-Wunused-variable",`
`40`	`40`	`"-Wunused-volatile-lvalue",`
`41`	`41`	`"-Wused-but-marked-unused",`
	`42`	`+ "-Wno-unused-parameter", # Enabled by -Wall via -Wunused, problems with params used in asserts.`
`42`	`43`	`]`
`43`	`44`
`44`	`45`	`def strict_warnings_objc_library(`