Skip to content

Commit 258fd9e

Browse files
author
Jeff Verkoeyen
committed
Remove private_header_files from podspec.
Summary: Removing this value in the podspec allows Swift apps with `use_frameworks!` to build successfully. The error this resolves is "Use of private header from outside its module: 'Private/MDCButton+Subclassing.h'". Apps can only use 'public' headers via CocoaPods, so we aren't exposing these private headers by removing the private access bit. Closes https://github.com/google/material-components-ios/issues/93. Reviewers: #material_components_ios_owners, ajsecord Reviewed By: #material_components_ios_owners, ajsecord Projects: #material_components_ios Differential Revision: http://codereview.cc/D138
1 parent 76f6876 commit 258fd9e

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

material-components-ios.podspec

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ Pod::Spec.new do |s|
1919
#
2020
# ## Optional properties
2121
#
22-
# private_header_files => This should point to your component's private/ directory if you have any
23-
# private headers.
2422
# resource_bundles => If your component has a bundle, add a dictionary mapping from the bundle
2523
# name to the bundle path.
2624
#
@@ -33,9 +31,6 @@ Pod::Spec.new do |s|
3331
# ss.source_files = 'components/ComponentName/src/*.{h,m}', 'components/ComponentName/src/private/*.{h,m}'
3432
# ss.header_mappings_dir = 'components/ComponentName/src/*'
3533
#
36-
# # Only if you have private headers
37-
# ss.private_header_files = 'components/ComponentName/src/private/*.h'
38-
#
3934
# # Only if you have a resource bundle
4035
# ss.resource_bundles = {
4136
# 'MaterialComponentName' => ['components/ComponentName/MaterialComponentName.bundle/*']
@@ -45,9 +40,8 @@ Pod::Spec.new do |s|
4540

4641
s.subspec 'Buttons' do |ss|
4742
ss.public_header_files = 'components/Buttons/src/*.h'
48-
ss.source_files = 'components/Buttons/src/*.{h,m}', 'components/Buttons/src/private/*.{h,m}'
43+
ss.source_files = 'components/Buttons/src/*.{h,m}', 'components/Buttons/src/Private/*.{h,m}'
4944
ss.header_mappings_dir = 'components/Buttons/src/*'
50-
ss.private_header_files = 'components/Buttons/src/Private/*.h'
5145
ss.dependency 'material-components-ios/Ink'
5246
ss.dependency 'material-components-ios/ShadowElevations'
5347
ss.dependency 'material-components-ios/ShadowLayer'
@@ -58,14 +52,12 @@ Pod::Spec.new do |s|
5852
ss.public_header_files = 'components/FlexibleHeader/src/*.h'
5953
ss.source_files = 'components/FlexibleHeader/src/*.{h,m}', 'components/FlexibleHeader/src/private/*.{h,m}'
6054
ss.header_mappings_dir = 'components/FlexibleHeader/src/*'
61-
ss.private_header_files = 'components/FlexibleHeader/src/private/*.h'
6255
end
6356

6457
s.subspec 'Ink' do |ss|
6558
ss.public_header_files = 'components/Ink/src/*.h'
6659
ss.source_files = 'components/Ink/src/*.{h,m}', 'components/Ink/src/private/*.{h,m}'
6760
ss.header_mappings_dir = 'components/Ink/src/*'
68-
ss.private_header_files = 'components/Ink/src/private/*.h'
6961
end
7062

7163
s.subspec 'PageControl' do |ss|
@@ -120,7 +112,6 @@ Pod::Spec.new do |s|
120112
ss.source_files = 'components/Typography/src/*.{h,m}', 'components/Typography/src/Private/*.{h,m}'
121113
ss.header_mappings_dir = 'components/Typography/src/*'
122114

123-
ss.private_header_files = 'components/Typography/src/Private/*.h'
124115
ss.resource_bundles = {
125116
'MaterialTypography' => ['components/Typography/src/MaterialTypography.bundle/*']
126117
}

0 commit comments

Comments
 (0)