Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Commit dfe8a43

Browse files
author
Nick Rout
committed
Add support for ColorScheme.scrim
1 parent 2930319 commit dfe8a43

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

material3Lib/src/androidTest/java/com/google/android/material/composethemeadapter3/test/Mdc3ThemeTest.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,15 @@ class Mdc3ThemeTest {
8383
Assert.assertEquals(colorResource(R.color.orchid), colorScheme.inverseOnSurface)
8484

8585
Assert.assertEquals(colorResource(R.color.violet), colorScheme.outline)
86+
// TODO: MDC-Android doesn't include outlineVariant yet, add when available
8687

8788
Assert.assertEquals(colorResource(R.color.beige), colorScheme.error)
8889
Assert.assertEquals(colorResource(R.color.white_smoke), colorScheme.onError)
8990
Assert.assertEquals(colorResource(R.color.olive), colorScheme.errorContainer)
9091
Assert.assertEquals(colorResource(R.color.olive_drab), colorScheme.onErrorContainer)
9192

93+
Assert.assertEquals(colorResource(R.color.crimson), colorScheme.scrim)
94+
9295
// Mdc3Theme updates the LocalContentColor to match the calculated onBackground
9396
Assert.assertEquals(colorResource(R.color.navy), LocalContentColor.current)
9497
}

material3Lib/src/androidTest/res/values/test_colors.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
<color name="medium_spring_green">#00FA9A</color>
3434
<color name="navy">#000080</color>
3535
<color name="dark_blue">#00008B</color>
36+
<color name="crimson">#DC143C</color>
3637
<color name="indian_red">#CD5C5C</color>
3738
<color name="light_coral">#F08080</color>
3839
<color name="salmon">#FA8072</color>

material3Lib/src/androidTest/res/values/themes.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@
4242
<item name="colorSurfaceInverse">@color/light_salmon</item>
4343
<item name="colorOnSurfaceInverse">@color/orchid</item>
4444
<item name="colorOutline">@color/violet</item>
45+
<!-- TODO: MDC-Android doesn't include outlineVariant yet, add when available -->
4546
<item name="colorError">@color/beige</item>
4647
<item name="colorOnError">@color/white_smoke</item>
4748
<item name="colorErrorContainer">@color/olive</item>
4849
<item name="colorOnErrorContainer">@color/olive_drab</item>
50+
<item name="scrimBackground">@color/crimson</item>
4951

5052
<!-- Text Appearances -->
5153
<item name="textAppearanceDisplayLarge">@style/TextAppearance.Mdc3ThemeTest.DisplayLarge</item>

material3Lib/src/main/java/com/google/android/material/composethemeadapter3/Mdc3Theme.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ fun createMdc3Theme(
189189
val onError = ta.getComposeColor(R.styleable.ComposeThemeAdapterTheme_colorOnError)
190190
val errorContainer = ta.getComposeColor(R.styleable.ComposeThemeAdapterTheme_colorErrorContainer)
191191
val onErrorContainer = ta.getComposeColor(R.styleable.ComposeThemeAdapterTheme_colorOnErrorContainer)
192+
val scrimBackground = ta.getComposeColor(R.styleable.ComposeThemeAdapterTheme_scrimBackground)
192193

193194
val isLightTheme = ta.getBoolean(R.styleable.ComposeThemeAdapterTheme_isLightTheme, true)
194195

@@ -217,10 +218,12 @@ fun createMdc3Theme(
217218
inverseSurface = surfaceInverse,
218219
inverseOnSurface = onSurfaceInverse,
219220
outline = outline,
221+
// TODO: MDC-Android doesn't include outlineVariant yet, add when available
220222
error = error,
221223
onError = onError,
222224
errorContainer = errorContainer,
223-
onErrorContainer = onErrorContainer
225+
onErrorContainer = onErrorContainer,
226+
scrim = scrimBackground
224227
)
225228
} else {
226229
darkColorScheme(
@@ -247,10 +250,12 @@ fun createMdc3Theme(
247250
inverseSurface = surfaceInverse,
248251
inverseOnSurface = onSurfaceInverse,
249252
outline = outline,
253+
// TODO: MDC-Android doesn't include outlineVariant yet, add when available
250254
error = error,
251255
onError = onError,
252256
errorContainer = errorContainer,
253-
onErrorContainer = onErrorContainer
257+
onErrorContainer = onErrorContainer,
258+
scrim = scrimBackground
254259
)
255260
}
256261
} else null

material3Lib/src/main/res/values/theme_attrs.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
<attr name="colorOnError" />
4848
<attr name="colorErrorContainer" />
4949
<attr name="colorOnErrorContainer" />
50+
<attr name="scrimBackground" />
5051

5152
<attr name="fontFamily" />
5253
<attr name="android:fontFamily" />

0 commit comments

Comments
 (0)