Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Commit 477023a

Browse files
author
Nick Rout
committed
Fix tests
1 parent 550fe1e commit 477023a

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

material3Lib/src/androidTest/java/com/google/android/material/composethemeadapter3/Mdc3ThemeTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ class Mdc3ThemeTest {
7171
Assert.assertEquals(colorResource(R.color.light_coral), colorScheme.onSurface)
7272
Assert.assertEquals(colorResource(R.color.salmon), colorScheme.surfaceVariant)
7373
Assert.assertEquals(colorResource(R.color.dark_salmon), colorScheme.onSurfaceVariant)
74+
Assert.assertEquals(colorResource(R.color.indian_red), colorScheme.surfaceTint)
7475
Assert.assertEquals(colorResource(R.color.light_salmon), colorScheme.inverseSurface)
7576
Assert.assertEquals(colorResource(R.color.orchid), colorScheme.inverseOnSurface)
7677

material3Lib/src/androidTest/res/values/test_colors.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
<color name="medium_spring_green">#00FA9A</color>
3434
<color name="navy">#000080</color>
3535
<color name="dark_blue">#00008B</color>
36+
<color name="indian_red">#CD5C5C</color>
3637
<color name="light_coral">#F08080</color>
3738
<color name="salmon">#FA8072</color>
3839
<color name="dark_salmon">#E9967A</color>

material3Lib/src/androidTest/res/values/themes.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
<item name="colorOnSurface">@color/light_coral</item>
3939
<item name="colorSurfaceVariant">@color/salmon</item>
4040
<item name="colorOnSurfaceVariant">@color/dark_salmon</item>
41+
<item name="elevationOverlayColor">@color/indian_red</item>
4142
<item name="colorSurfaceInverse">@color/light_salmon</item>
4243
<item name="colorOnSurfaceInverse">@color/orchid</item>
4344
<item name="colorOutline">@color/violet</item>

materialLib/src/androidTest/java/com/google/android/material/composethemeadapter/MdcThemeTest.kt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import androidx.compose.foundation.shape.RoundedCornerShape
2323
import androidx.compose.material.LocalContentColor
2424
import androidx.compose.material.MaterialTheme
2525
import androidx.compose.ui.geometry.Size
26-
import androidx.compose.ui.platform.LocalContext
2726
import androidx.compose.ui.platform.LocalDensity
2827
import androidx.compose.ui.res.colorResource
2928
import androidx.compose.ui.test.junit4.createAndroidComposeRule
@@ -71,15 +70,7 @@ class MdcThemeTest<T : AppCompatActivity>(activityClass: Class<T>) {
7170

7271
assertEquals(colorResource(R.color.dark_golden_rod), color.secondary)
7372
assertEquals(colorResource(R.color.slate_gray), color.onSecondary)
74-
75-
// We don't check isSystemInDarkTheme() here since that only checks the system
76-
// dark theme setting: https://issuetracker.google.com/163103826
77-
if (LocalContext.current.isInDarkTheme()) {
78-
// In dark theme secondaryVariant is ignored and always return secondary
79-
assertEquals(colorResource(R.color.dark_golden_rod), color.secondaryVariant)
80-
} else {
81-
assertEquals(colorResource(R.color.blue_violet), color.secondaryVariant)
82-
}
73+
assertEquals(colorResource(R.color.blue_violet), color.secondaryVariant)
8374

8475
assertEquals(colorResource(R.color.spring_green), color.surface)
8576
assertEquals(colorResource(R.color.navy), color.onSurface)

0 commit comments

Comments
 (0)