Merge pull request #477 from suola/falcon-parser-wsgi-ref-read-requires-argument

stdlib `wsgiref` requires argument for `read()`

Author: lafrech

AUTHORS.rst

@@ -46,3 +46,4 @@ Contributors (chronological)
 * `@dodumosu <https://github.com/dodumosu>`_
 * Nate Dellinger `@Nateyo <https://github.com/Nateyo>`_
 * Karthikeyan Singaravelan `@tirkarthi <https://github.com/tirkarthi>`_
+* Sami Salonen `@suola <https://github.com/suola>`_

src/webargs/falconparser.py

@@ -103,7 +103,7 @@ def _raw_load_json(self, req):
         non-json, even if the request body is parseable as json."""
         if not is_json_request(req) or req.content_length in (None, 0):
             return core.missing
-        body = req.stream.read()
+        body = req.stream.read(req.content_length)
         if body:
             return core.parse_json(body)
         else:

tests/test_falconparser.py

@@ -1,4 +1,5 @@
 import pytest
+import falcon.testing
 
 from webargs.testing import CommonTestCase
 from tests.apps.falcon_app import create_app
@@ -42,3 +43,10 @@ def test_invalid_json(self, testapp):
     def test_parsing_headers(self, testapp):
         res = testapp.get("/echo_headers", headers={"name": "Fred"})
         assert res.json == {"NAME": "Fred"}
+
+    # `falcon.testing.TestClient.simulate_request` parses request with `wsgiref`
+    def test_body_parsing_works_with_simulate(self):
+        app = self.create_app()
+        client = falcon.testing.TestClient(app)
+        res = client.simulate_post("/echo_json", json={"name": "Fred"},)
+        assert res.json == {"name": "Fred"}