Skip to content

Commit 3a986fc

Browse files
committed
Fix load parameter *unknow* propagation
When deserializing a data structure with the load method, the *unknown* was not propagated to the loading of nested data structures. As result, if a unknown field was present into a nested data structure a ValidationError was raised even if the load methd was called with *unknown=EXCLUDE*. This commit ensures that this parameter is now propagated also to the loading of nested data structures. fixes #1428
1 parent a74f38d commit 3a986fc

File tree

4 files changed

+31
-5
lines changed

4 files changed

+31
-5
lines changed

AUTHORS.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,3 +140,4 @@ Contributors (chronological)
140140
- `@phrfpeixoto <https://github.com/phrfpeixoto>`_
141141
- `@jceresini <https://github.com/jceresini>`_
142142
- Nikolay Shebanov `@killthekitten <https://github.com/killthekitten>`_
143+
- Laurent Mignon `@lmignon <https://github.com/lmignon>`_

src/marshmallow/fields.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -567,29 +567,36 @@ def _test_collection(self, value, many=False):
567567
if many and not utils.is_collection(value):
568568
raise self.make_error("type", input=value, type=value.__class__.__name__)
569569

570-
def _load(self, value, data, partial=None, many=False):
570+
def _load(self, value, data, partial=None, many=False, unknown=None):
571571
many = self.schema.many or self.many or many
572+
unknown = unknown or self.unknown
572573
try:
573574
valid_data = self.schema.load(
574-
value, unknown=self.unknown, partial=partial, many=many
575+
value, unknown=unknown, partial=partial, many=many
575576
)
576577
except ValidationError as error:
577578
raise ValidationError(
578579
error.messages, valid_data=error.valid_data
579580
) from error
580581
return valid_data
581582

582-
def _deserialize(self, value, attr, data, partial=None, many=False, **kwargs):
583+
def _deserialize(
584+
self, value, attr, data, partial=None, many=False, unknown=None, **kwargs
585+
):
583586
"""Same as :meth:`Field._deserialize` with additional ``partial`` argument.
584587
585588
:param bool|tuple partial: For nested schemas, the ``partial``
586589
parameter passed to `Schema.load`.
590+
:param unknown: For nested schemas, the ``unknown``
591+
parameter passed to `Schema.load`..
587592
588593
.. versionchanged:: 3.0.0
589594
Add ``partial`` parameter.
595+
.. versionchanged:: 3.2.2
596+
Add ``unknown`` parameter.
590597
"""
591598
self._test_collection(value, many=many)
592-
return self._load(value, data, partial=partial, many=many)
599+
return self._load(value, data, partial=partial, many=many, unknown=unknown)
593600

594601

595602
class Pluck(Nested):

src/marshmallow/schema.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,7 @@ def _deserialize(
652652
d_kwargs["partial"] = sub_partial
653653
else:
654654
d_kwargs["partial"] = partial
655+
d_kwargs["unknown"] = unknown
655656
getter = lambda val: field_obj.deserialize(
656657
val, field_name, data, **d_kwargs
657658
)
@@ -665,6 +666,7 @@ def _deserialize(
665666
if value is not missing:
666667
key = field_obj.attribute or attr_name
667668
set_value(typing.cast(typing.Dict, ret), key, value)
669+
unknown = unknown or self.unknown
668670
if unknown != EXCLUDE:
669671
fields = {
670672
field_obj.data_key if field_obj.data_key is not None else field_name
@@ -823,7 +825,6 @@ def _do_load(
823825
error_store = ErrorStore()
824826
errors = {} # type: typing.Dict[str, typing.List[str]]
825827
many = self.many if many is None else bool(many)
826-
unknown = unknown or self.unknown
827828
if partial is None:
828829
partial = self.partial
829830
# Run preprocessors

tests/test_schema.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,23 @@ class Outer(Schema):
289289
assert Outer().load({"list1": val, "list2": val}) == {"list1": [], "list2": []}
290290

291291

292+
@pytest.mark.parametrize(
293+
"val",
294+
(
295+
{"inner": {"name": "name"}, "unknown": 1},
296+
{"inner": {"name": "name", "unknown_nested": 1}, "unknown": 1},
297+
),
298+
)
299+
def test_load_unknown(val):
300+
class Inner(Schema):
301+
name = fields.String()
302+
303+
class Outer(Schema):
304+
inner = fields.Nested(Inner)
305+
306+
assert Outer().load(val, unknown=EXCLUDE) == {"inner": {"name": "name"}}
307+
308+
292309
def test_loads_returns_a_user():
293310
s = UserSchema()
294311
result = s.loads(json.dumps({"name": "Monty"}))

0 commit comments

Comments
 (0)