Don't panic

[markus-wa]

Generally, errors should be returned instead of panicking.

[thedjinn]

Any update on this? This issue causes demoinfocs-golang to panic when its provided io.Reader produces an error on first read.

[markus-wa]

Hey @thedjinn - I never bothered to implement this as it's a lot of work and I'm not sure of the performance-impact it would have when no errors happen (this lib is already the bottleneck in my usecase).

It's also quite bad that it already happens on Open() istead of the first read call (honestly, there's a lot I'd do differently today).

If you would be interested in creating a PR I would like to see this changed - but between work and my other projects I simply don't have the time to do it myself right now, sorry.

Maybe a good first start would be to return errors inOpen() and OpenWithBuffer()? that would take care of all cases where the reader is broken. Even better would be refactoring the code so Open() doesn't do a Read() at all though.