Not logging message when no documents fail

Author: rjrudin

src/main/java/com/marklogic/spark/writer/WriteBatcherDataWriter.java

@@ -228,7 +228,9 @@ private ZipFileWriter createArchiveWriter(SerializableConfiguration hadoopConfig
 
     private void closeArchiveWriter() {
         if (archiveWriter != null) {
-            Util.MAIN_LOGGER.info("Wrote failed documents to archive file at {}.", archiveWriter.getZipPath());
+            if (failedItemCount.get() > 0) {
+                Util.MAIN_LOGGER.info("Wrote failed documents to archive file at {}.", archiveWriter.getZipPath());
+            }
             archiveWriter.close();
         }
     }

src/test/java/com/marklogic/spark/writer/WriteArchiveOfFailedDocumentsTest.java

@@ -21,7 +21,8 @@
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicInteger;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class WriteArchiveOfFailedDocumentsTest extends AbstractWriteTest {
 
@@ -64,6 +65,18 @@ void happyPath(@TempDir Path tempDir) {
         verifyArchiveRows(rows);
     }
 
+    @Test
+    void noFailures(@TempDir Path tempDir) {
+        newWriter(1)
+            .option(Options.WRITE_ABORT_ON_FAILURE, false)
+            .option(Options.WRITE_ARCHIVE_PATH_FOR_FAILED_DOCUMENTS, tempDir.toFile().getAbsolutePath())
+            .save();
+
+        assertCollectionSize("This test is for manual inspection of the logs to ensure that no message is " +
+                "logged indicating that an archive file of failed documents was written when there are no errors.",
+            COLLECTION, 200);
+    }
+
     @Test
     void multiplePartitions(@TempDir Path tempDir) {
         defaultWrite(newSparkSession().read().format(CONNECTOR_IDENTIFIER)