Creating parameters with name of existing parameters - behaviour?

[Ploppz]

Two times I have reproduced that creating a parameter with the name of an existing parameter from another division, fails to insert the new parameter but does not throw an error.

It should be possible for parameters to have the same name as their primary key is id.

This needs to be tested/debugged more.

[Ploppz]

I figured that this is reflected in the code: if a parameter has the same "description", the existing parameter will be used insted of creating a new one.

                parameter = self.database.get_session() \
                    .query(self.Parameter) \
                    .filter(value.strip().lower() == func.lower(self.Parameter.description)) \
                    .first()

                if parameter is None:
                    # Create new Parameter only if it does not exist
                    parameter = self.Parameter(description=value.strip())
                    self.database.get_session().add(parameter)
                    self.parameters[param_nr] = parameter
                else:
                    # Parameter already exists - Don't create it, just add it to the Division
                    # Setting it to None here signifies for later that we should not add a specialization for it
                    self.parameters[param_nr] = None
                    pass
                division.parameters.append(parameter)

If we really want it this way, we should make description primary key and remove id. Furthermore, we should make it clear to the user that a different parameter than the requested one is being used. But it probably makes more sense to ask the user to provide a different name. Still think it may be a good idea to let description be primary key. I suppose that later, we will make it possible for the user to reuse existing parameters.

[Ploppz]

4883a26 actually fixed issue #58 not #59...