Skip to content

Commit 35f3c03

Browse files
authored
Merge pull request talaia-labs#73 from sr-gi/fix-readmes
Fixes some typos in the readmes
2 parents 91aaa00 + a70f9c4 commit 35f3c03

File tree

5 files changed

+55
-37
lines changed

5 files changed

+55
-37
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ We use `rustfmt` as our base code formatter. Before submitting a PR make sure yo
99
cargo fmt
1010
```
1111

12-
In addition, we use [clippy](https://github.com/rust-lang/rust-clippy/) to detect catch common mistakes and improve the code:
12+
In addition, we use [clippy](https://github.com/rust-lang/rust-clippy/) to catch common mistakes and improve the code:
1313

1414
```bash
1515
cargo clippy
@@ -70,8 +70,8 @@ pub struct Responder {
7070
```
7171

7272
## Test Coverage
73-
Tests should be provided to cover both positive and negative conditions. Test should cover both the proper execution as well as all the covered error paths. PR with no proper test coverage will be rejected.
73+
Tests should be provided to cover both positive and negative conditions. Tests should cover both the proper execution as well as all the covered error paths. PR with no proper test coverage will not be merged.
7474

7575
## Signing Commits
7676

77-
We require that all commits to be merge into master are signed. You can enable commit signing on GitHub by following [Signing commits](https://help.github.com/en/github/authenticating-to-github/signing-commits).
77+
We require that all commits to be merged into master are signed. You can enable commit signing on GitHub by following [Signing commits](https://help.github.com/en/github/authenticating-to-github/signing-commits).

DEPENDENCIES.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependencies
22

3-
`rusty-teos` has the following system-wide dependencies:
3+
`rust-teos` has the following system-wide dependencies:
44

55
- `rust`
66
- `bitcoind`
@@ -13,7 +13,7 @@ Refer to [rust-lang.org](https://www.rust-lang.org/tools/install).
1313

1414
### Installing bitcoind
1515

16-
`rusty-teos` runs on top of a Bitcoin Core node. Other underlying Bitcoin nodes are not supported at the moment.
16+
`rust-teos` runs on top of a Bitcoin Core node. Other underlying Bitcoin nodes are not supported at the moment.
1717

1818
You can get Bitcoin Core from [bitcoincore.org](https://bitcoincore.org/en/download/).
1919

INSTALL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
The tower can be installed and tested using cargo:
44

55
```
6-
git https://github.com/sr-gi/rusty-teos.git
7-
cd rusty-teos
6+
git clone https://github.com/sr-gi/rust-teos.git
7+
cd rust-teos
88
cargo install --path teos
99
```
1010

README.md

Lines changed: 26 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55
The Eye of Satoshi is a Lightning watchtower compliant with [BOLT13](https://github.com/sr-gi/bolt13), written in Rust.
66

7-
`rust-teos` consists in two main crates:
7+
`rust-teos` consists of two main crates:
88

9-
- `teos`: including the tower's main functionality (server-side) and a CLI.
10-
- `teos-common`: including shared functionality between server and client side (useful to build a client).
9+
- `teos`: including the tower's main functionality (server-side) and a CLI. Compiling this crate will generate two binaries: `teosd` and `teos-cli`.
10+
- `teos-common`: including shared functionality between server and client-side (useful to build a client).
1111

1212
## Dependencies
1313

@@ -18,8 +18,7 @@ Refer to [INSTALL.md](INSTALL.md)
1818

1919
## Running TEOS
2020

21-
Make sure bitcoind is running before running `rust-teos` (it will fail at startup if it cannot connect to bitcoind). You can find
22-
[here](DEPENDENCIES.md#installing-bitcoind) a sample config file.
21+
Make sure `bitcoind` is running before running `teosd` (it will fail at startup if it cannot connect to `bitcoind`). [Here](DEPENDENCIES.md#installing-bitcoind) you can find a sample bitcoin.conf.
2322

2423
### Starting the tower daemon ♖
2524

@@ -31,31 +30,31 @@ teosd
3130

3231
### Configuration file and command line parameters
3332

34-
`rust-teos` comes with a default configuration that can be found at [teos/src/config.rs](teos/src/config.rs).
33+
`teosd` comes with a default configuration that can be found at [teos/src/config.rs](teos/src/config.rs).
3534

3635
The configuration includes, amongst others, where your data folder is placed, what network it connects to, etc.
3736

3837
To change the configuration defaults you can:
3938

40-
- Define a configuration file named `teos.toml` following the template (check [teos/src/conf_template.toml](teos/src/conf_template.toml)) and place it in the `data_dir` (that defaults to `~/.teos/`)
39+
- Define a configuration file named `teos.toml` following the template (check [conf_template.toml](teos/src/conf_template.toml)) and place it in the `data_dir` (that defaults to `~/.teos/`).
4140

42-
and / or
41+
and/or
4342

4443
- Add some global options when running the daemon (run `teosd -h` for more info).
4544

46-
### Passing command line options to `teosd`
45+
### Passing command-line options to `teosd`
4746

48-
Some configuration options can also be passed as options when running `teosd`. We can, for instance, change the tower data directory as follows:
47+
Some configuration options can also be specified when running `teosd`. We can, for instance, change the tower data directory as follows:
4948

5049
```
5150
teosd --datadir=<path_to_dir>
5251
```
5352

54-
### Running TEOS in another network
53+
### Running `teosd` in another network
5554

56-
By default, `rust-teos` runs on `mainnet`. In order to run it on another network you need to change the network parameter in the configuration file or pass the network parameter as a command line option. Notice that if teos does not find a `bitcoind` node running in the same network that it is set to run, it will refuse to run.
55+
By default, `teosd` runs on `mainnet`. In order to run it on another network, you need to change the network parameter in the configuration file or pass the network parameter as a command-line option. Notice that if `teosd` does not find a `bitcoind` node running in the same network that it is set to run, it will refuse to run.
5756

58-
The configuration file option to change the network where `teos` will run is `btc_network`:
57+
The configuration file option to change the network where `teosd` will run is `btc_network`:
5958

6059
```
6160
btc_network = mainnet
@@ -67,15 +66,14 @@ For regtest, it should look like:
6766
btc_network = regtest
6867
```
6968

70-
### Running TEOS with tor
69+
### Running `teosd` with tor
7170

72-
This requires a tor deamon running on the same machine as teos and a control port open on that deamon.
71+
This requires a tor daemon running on the same machine as `teosd` and a control port open on that daemon.
7372

74-
Download tor from the torproject site here: [torproject](https://www.torproject.org/download/)
73+
Download tor from the [torproject site](https://www.torproject.org/download/).
7574

76-
To open tor's control port, follow the instructions here on how to update the configuration file [tor conf](https://2019.www.torproject.org/docs/faq.html.en#torrc)
75+
To open tor's control port, you add the following to the tor config file ([source](https://2019.www.torproject.org/docs/faq.html.en#torrc)):
7776

78-
Add the following lines to the file:
7977
```
8078
## The port on which Tor will listen for local connections from Tor
8179
## controller applications, as documented in control-spec.txt.
@@ -87,19 +85,19 @@ CookieAuthentication 1
8785
CookieAuthFileGroupReadable 1
8886
```
8987

90-
Once the tor deamon is running, and the control port is open, make sure to change `tor_support` flag to true in teos conf.
88+
Once the tor daemon is running, and the control port is open, make sure to enable the `tor_support` flag `teosd`.
9189

9290
### Tower id and signing key
9391

94-
`teos` needs a pair of keys that will serve as tower id and signing key. The former can be used by users to identify the tower, whereas the latter is used by the tower to sign responses. These keys are automatically generated on the first run, and can be refreshed by running `teos` with the `--overwritekey` flag. Notice that once a key is overwritten you won't be able to use the previous key again*.
92+
`teosd` needs a pair of keys that will serve as tower id and signing key. The former can be used by users to identify the tower, whereas the latter is used by the tower to sign responses. These keys are automatically generated on the first run and can be refreshed by running `teosd` with the `--overwritekey` flag. Notice that once a key is overwritten you won't be able to use the previous key again*.
9593

96-
\* Old keys are actually kept in the tower's database as a fail safe in case you overwrite them by mistake. However, there is no automated way of switching back to and old key. Feel free to open an issue if you overwrote your key by mistake and need support to recover it.
94+
\* Old keys are actually kept in the tower's database as a fail-safe in case you overwrite them by mistake. However, there is no automated way of switching back to an old key. Feel free to open an issue if you overwrote your key by mistake and need support to recover it.
9795

98-
## Interacting with a TEOS Instance
96+
## Interacting with a TEOS instance
9997

100-
You can interact with a `teos` instance (either run by yourself or someone else) by using `teos-cli`. This is an admin tool that has privileged access to the watchtower, and it should therefore only be used within a trusted environment (for example, the same machine).
98+
You can interact with a `teosd` instance (either run by yourself or someone else) by using `teos-cli`. This is an admin tool that has privileged access to the watchtower, and it should therefore only be used within a trusted environment (for example, the same machine).
10199

102-
While `teos-cli` works independently of `teos`, it shares the same configuration file by default, of which it only uses a subset of its settings. The folder can be changed using the `--datadir` command line argument, if desired.
100+
While `teos-cli` works independently of `teosd`, it shares the same configuration file by default, of which it only uses a subset of its settings. The folder can be changed using the `--datadir` command-line argument if desired.
103101

104102
For help on the available arguments and commands, you can run:
105103

@@ -109,16 +107,16 @@ teos-cli -h
109107

110108
### Running teos-cli remotely
111109

112-
To run `teos-cli` remotely, you'll need to take one extra step. When `teosd` is started up, self-signed certificates are automatically generated for a user to make a secure connection to the TEOS watchtower. When the CLI is run locally, it knows where to find these files. But if run remotely, these files need to be copied over to the machine where the CLI is being run.
110+
To run `teos-cli` remotely, you'll need to take one extra step. When `teosd` is started up, self-signed certificates are automatically generated for a user to make a secure connection to the remote TEOS watchtower. When the CLI is run locally, it knows where to find these files. But if run remotely, these files need to be copied over to the machine where the CLI is being run.
113111

114-
The files are generated to the data directory (by default stored at `~/.teos`). To run remotely, users need to copy the `client.pem`, `client-key.pem`, and `ca.pem` files to the corresponding watchtower data directory on the machine where the CLI is being run.
112+
The files are generated to the data directory (by default stored at `~/.teos/`). To run remotely, users need to copy the `client.pem`, `client-key.pem`, and `ca.pem` files to the corresponding watchtower data directory on the machine where the CLI is being run. That is, by default, to `~/.teos/` on the remote machine.
115113

116114
## Interacting with TEOS as a client
117-
## TEOS clients
115+
### TEOS clients
118116

119117
Here is a list of the available clients for `teos`:
120118

121-
- [watchtower-plugin for CLN](watchtower-plugin/)
119+
- [watchtower-client for CLN](watchtower-plugin/)
122120

123121
## Contributing
124122
Refer to [CONTRIBUTING.md](CONTRIBUTING.md)

watchtower-plugin/README.md

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ cd ~/.lightning
4747
mkdir plugins && cd plugins
4848
```
4949

50-
Now you need to place the watchtower-client to this folder. To do so we will create a symbolic link to it. First, check where the binary is placed (this is usually placed in your user's home).
50+
Now you need to place the watchtower-client into this folder. To do so we will create a symbolic link to it. First, check where the binary is placed (this is usually placed in your user's home).
5151

5252
```
5353
whereis watchtower-client
5454
> watchtower-client: <your_user_home>/.cargo/bin/watchtower-client
5555
```
5656

57-
Notice that here, `<your_user_home>` will be the path to your users home directory, for instance `/home/sergi/`.
57+
Notice that here `<your_user_home>` will be the path to your user's home directory, for instance `/home/sergi/`.
5858

5959
Now create a symbolic link to it (make sure to replace the path for your's!):
6060

@@ -71,6 +71,26 @@ ls
7171

7272
You can now turn on your lightning node and the plugin will be automatically linked.
7373

74+
### Check that the client is properly linked
75+
76+
We can check the plugin was properly linked by running:
77+
78+
```
79+
lightning-cli plugin list
80+
```
81+
82+
That will return a list of all linked plugins, which should include the `watchtower-client`:
83+
84+
```
85+
[
86+
...
87+
{
88+
"name": "~/.lightning/plugins/watchtower-client",
89+
"active": true
90+
}
91+
]
92+
```
93+
7494
# Config file, data folder and first bootstrap
7595

7696
The plugin, by default, creates a data folder under the user's home folder (`~/.watchtower`), where all the plugin's data is stored. The data folder can be modified by setting the ENV variable `TOWERS_DATA_DIR`.

0 commit comments

Comments
 (0)