Bug 1565010 - Fix intermittent on browser_webconsole_warn_about_replaced_api.js .r=Honza.

marco-c · marco-c · commit fc20ff1ab460 · 2020-04-25T19:08:16.000Z
Log the console replaced message only after the current batch of messages are consumed. We also enable the timestamp in the test, so in case of failure we can diagnose what's going on better. Differential Revision: https://phabricator.services.mozilla.com/D72121 UltraBlame original commit: d321839de1603d8bf02752ebaa40434015149320
diff --git a/devtools/client/webconsole/test/browser/browser_webconsole_warn_about_replaced_api.js b/devtools/client/webconsole/test/browser/browser_webconsole_warn_about_replaced_api.js
@@ -105,15 +105,21 @@ function
 )
 {
 await
-SpecialPowers
+pushPref
+(
+"
+devtools
 .
-pushPrefEnv
+webconsole
+.
+timestampMessages
+"
+true
+)
+;
+await
+pushPref
 (
-{
-set
-:
-[
-[
 "
 devtools
 .
@@ -122,9 +128,6 @@ webconsole
 persistlog
 "
 true
-]
-]
-}
 )
 ;
 let
diff --git a/devtools/client/webconsole/webconsole-ui.js b/devtools/client/webconsole/webconsole-ui.js
@@ -3438,21 +3438,6 @@ handleTabNavigated
 packet
 )
 {
-if
-(
-!
-packet
-.
-nativeConsoleAPI
-)
-{
-this
-.
-logWarningAboutReplacedAPI
-(
-)
-;
-}
 /
 /
 Wait
@@ -3485,6 +3470,21 @@ waitAsyncDispatches
 (
 )
 ;
+if
+(
+!
+packet
+.
+nativeConsoleAPI
+)
+{
+this
+.
+logWarningAboutReplacedAPI
+(
+)
+;
+}
 this
 .
 emit

Original file line number	Diff line number	Diff line change
`@@ -105,15 +105,21 @@ function`
`105`	`105`	`)`
`106`	`106`	`{`
`107`	`107`	`await`
`108`		`-SpecialPowers`
	`108`	`+pushPref`
	`109`	`+(`
	`110`	`+"`
	`111`	`+devtools`
`109`	`112`	`.`
`110`		`-pushPrefEnv`
	`113`	`+webconsole`
	`114`	`+.`
	`115`	`+timestampMessages`
	`116`	`+"`
	`117`	`+true`
	`118`	`+)`
	`119`	`+;`
	`120`	`+await`
	`121`	`+pushPref`
`111`	`122`	`(`
`112`		`-{`
`113`		`-set`
`114`		`-:`
`115`		`-[`
`116`		`-[`
`117`	`123`	`"`
`118`	`124`	`devtools`
`119`	`125`	`.`
`@@ -122,9 +128,6 @@ webconsole`
`122`	`128`	`persistlog`
`123`	`129`	`"`
`124`	`130`	`true`
`125`		`-]`
`126`		`-]`
`127`		`-}`
`128`	`131`	`)`
`129`	`132`	`;`
`130`	`133`	`let`
Original file line number	Diff line number	Diff line change
`@@ -3438,21 +3438,6 @@ handleTabNavigated`
`3438`	`3438`	`packet`
`3439`	`3439`	`)`
`3440`	`3440`	`{`
`3441`		`-if`
`3442`		`-(`
`3443`		`-!`
`3444`		`-packet`
`3445`		`-.`
`3446`		`-nativeConsoleAPI`
`3447`		`-)`
`3448`		`-{`
`3449`		`-this`
`3450`		`-.`
`3451`		`-logWarningAboutReplacedAPI`
`3452`		`-(`
`3453`		`-)`
`3454`		`-;`
`3455`		`-}`
`3456`	`3441`	`/`
`3457`	`3442`	`/`
`3458`	`3443`	`Wait`
`@@ -3485,6 +3470,21 @@ waitAsyncDispatches`
`3485`	`3470`	`(`
`3486`	`3471`	`)`
`3487`	`3472`	`;`
	`3473`	`+if`
	`3474`	`+(`
	`3475`	`+!`
	`3476`	`+packet`
	`3477`	`+.`
	`3478`	`+nativeConsoleAPI`
	`3479`	`+)`
	`3480`	`+{`
	`3481`	`+this`
	`3482`	`+.`
	`3483`	`+logWarningAboutReplacedAPI`
	`3484`	`+(`
	`3485`	`+)`
	`3486`	`+;`
	`3487`	`+}`
`3488`	`3488`	`this`
`3489`	`3489`	`.`
`3490`	`3490`	`emit`